Skip to content

feat: support deletion for OCI storage#608

Merged
TerryHowe merged 2 commits into
oras-project:mainfrom
wangxiaoxuan273:oci-storage
Oct 7, 2023
Merged

feat: support deletion for OCI storage#608
TerryHowe merged 2 commits into
oras-project:mainfrom
wangxiaoxuan273:oci-storage

Conversation

@wangxiaoxuan273

Copy link
Copy Markdown
Contributor

Signed-off-by: Xiaoxuan Wang wangxiaoxuan119@gmail.com

Part 3/4 of #454

Based on draft PR #582

@codecov-commenter

codecov-commenter commented Sep 25, 2023

Copy link
Copy Markdown

Codecov Report

Merging #608 (0f9fe8f) into main (6456d16) will decrease coverage by 0.03%.
The diff coverage is 57.14%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

@@            Coverage Diff             @@
##             main     #608      +/-   ##
==========================================
- Coverage   74.80%   74.77%   -0.03%     
==========================================
  Files          58       58              
  Lines        5306     5313       +7     
==========================================
+ Hits         3969     3973       +4     
- Misses        985      987       +2     
- Partials      352      353       +1     
Files Coverage Δ
content/oci/storage.go 61.25% <57.14%> (-0.40%) ⬇️

@Wwwsylvia Wwwsylvia left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: Xiaoxuan Wang <wangxiaoxuan119@gmail.com>
Signed-off-by: Xiaoxuan Wang <wangxiaoxuan119@gmail.com>

@TerryHowe TerryHowe left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@TerryHowe TerryHowe merged commit 7eef77e into oras-project:main Oct 7, 2023
@wangxiaoxuan273 wangxiaoxuan273 deleted the oci-storage branch October 8, 2023 01:36
shizhMSFT pushed a commit that referenced this pull request Nov 20, 2023
Part 4/4 of #454 

This PR should be reviewed and merged after PR #606 #607 #608

---------

Signed-off-by: Xiaoxuan Wang <wangxiaoxuan119@gmail.com>
@Wwwsylvia Wwwsylvia mentioned this pull request Jan 26, 2024
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants