Skip to content

feat: Add 'MemoryStore'#602

Merged
Wwwsylvia merged 1 commit into
oras-project:mainfrom
uanid:feature/memory-store
Sep 20, 2023
Merged

feat: Add 'MemoryStore'#602
Wwwsylvia merged 1 commit into
oras-project:mainfrom
uanid:feature/memory-store

Conversation

@uanid

@uanid uanid commented Sep 19, 2023

Copy link
Copy Markdown
Contributor

Features:

  • Add MemoryStore

I submitted a pull request for MemoryStore to oras-credentials-go a week ago. However, the repository has since been deprecated. I've created an identical PR to this one.

Reference Issue: Here

Signed-off-by: Uanid <uanid@outlook.com>

@Wwwsylvia Wwwsylvia left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov-commenter

codecov-commenter commented Sep 19, 2023

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.64%. Comparing base (577bffe) to head (7dc9201).
Report is 59 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #602      +/-   ##
==========================================
+ Coverage   74.58%   74.64%   +0.06%     
==========================================
  Files          58       59       +1     
  Lines        5252     5266      +14     
==========================================
+ Hits         3917     3931      +14     
  Misses        983      983              
  Partials      352      352              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@TerryHowe TerryHowe left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants