feat: add type for failure during deleting dangling referrer index by qweeah · Pull Request #482 · oras-project/oras-go

qweeah · 2023-04-11T06:53:40Z

Resolves #479

Signed-off-by: Billy Zha <jinzha1@microsoft.com>

codecov-commenter · 2023-04-11T06:56:31Z

Codecov Report

Merging #482 (be342e1) into main (e8225cb) will increase coverage by 0.08%.
The diff coverage is 63.63%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##             main     #482      +/-   ##
==========================================
+ Coverage   72.84%   72.92%   +0.08%     
==========================================
  Files          49       49              
  Lines        4518     4528      +10     
==========================================
+ Hits         3291     3302      +11     
  Misses        919      919              
+ Partials      308      307       -1

Impacted Files	Coverage Δ
registry/remote/referrers.go	`92.04% <33.33%> (-4.30%)`	⬇️
registry/remote/repository.go	`68.87% <100.00%> (+0.64%)`	⬆️

Signed-off-by: Billy Zha <jinzha1@microsoft.com>

shizhMSFT

LGTM

sajayantony · 2023-04-11T15:44:24Z

Is the digest of the manifest that failed to be deleted included in the errro?

TerryHowe

LGTM

Although please answer Sajay's question. Digest appears to be included to me.

SteveLasker · 2023-04-11T18:25:31Z

I'm struggling to understand why we'd delete content for the user: #479 (comment)

qweeah · 2023-04-12T01:17:49Z

Is the digest of the manifest that failed to be deleted included in the error?

It implicitly implied in the ReferrersTag, will add subject descriptor so caller don't need to do reversed conversion for referrers tag schema.

Signed-off-by: Billy Zha <jinzha1@microsoft.com>

shizhMSFT

Since we may have more specific errors in the future. It would be better if we can introduce a generic error to avoid error type blow up.

A sample error can be

type ReferrersError struct {
    Op      string
    Subject ocispec.Descriptor
    Err     error
}

Other examples can be found by

Signed-off-by: Billy Zha <jinzha1@microsoft.com>

qweeah · 2023-04-12T07:25:42Z

type ReferrersError struct {
    Op      string
    Subject ocispec.Descriptor
    Err     error
}

Updated, made it more generic to a remote.IgnorableError, not only for referrers.

sajayantony · 2023-04-12T07:33:48Z

Ignorable is confusing to me. It’s up to the caller to decide that IMHO.

Signed-off-by: Billy Zha <jinzha1@microsoft.com>

shizhMSFT

@qweeah It would be better if we can have a runnable example to show how this error can be parsed. Basically, we can have a mock registry which does not support delete.

Signed-off-by: Billy Zha <jinzha1@microsoft.com>

shizhMSFT

LGTM

TerryHowe

LGTM

Signed-off-by: Billy Zha <jinzha1@microsoft.com>

Wwwsylvia

LGTM

feat: add type for failure during deleting dangling referrer index

b538391

Signed-off-by: Billy Zha <jinzha1@microsoft.com>

qweeah requested review from SteveLasker, Wwwsylvia, sajayantony and shizhMSFT as code owners April 11, 2023 06:53

Wwwsylvia reviewed Apr 11, 2023

View reviewed changes

Comment thread registry/remote/referrers.go Outdated

Comment thread registry/remote/referrers.go Outdated

Wwwsylvia requested changes Apr 11, 2023

View reviewed changes

Comment thread registry/remote/referrers.go Outdated

qweeah added 2 commits April 11, 2023 17:13

add error unwrap

be21035

Signed-off-by: Billy Zha <jinzha1@microsoft.com>

fix build

2f8764a

Signed-off-by: Billy Zha <jinzha1@microsoft.com>

qweeah force-pushed the dangling branch from e302fb0 to 2f8764a Compare April 11, 2023 09:28

refactor

75064c3

Signed-off-by: Billy Zha <jinzha1@microsoft.com>

shizhMSFT approved these changes Apr 11, 2023

View reviewed changes

TerryHowe approved these changes Apr 11, 2023

View reviewed changes

sajayantony reviewed Apr 11, 2023

View reviewed changes

Comment thread registry/remote/referrers.go Outdated

resolve comments

1f4a01e

Signed-off-by: Billy Zha <jinzha1@microsoft.com>

shizhMSFT requested changes Apr 12, 2023

View reviewed changes

use more generic err type

f0755de

Signed-off-by: Billy Zha <jinzha1@microsoft.com>

resolve comments

e9a187a

Signed-off-by: Billy Zha <jinzha1@microsoft.com>

sajayantony reviewed Apr 13, 2023

View reviewed changes

Comment thread registry/remote/errop/errors.go Outdated

shizhMSFT reviewed Apr 13, 2023

View reviewed changes

Comment thread registry/remote/referrers.go Outdated

Comment thread registry/remote/errop/errors.go Outdated

Comment thread registry/remote/referrers.go Outdated

Comment thread registry/remote/errop/errors.go Outdated

qweeah added 2 commits April 13, 2023 16:52

resolve comments

049128e

Signed-off-by: Billy Zha <jinzha1@microsoft.com>

resovle comments

e58b164

Signed-off-by: Billy Zha <jinzha1@microsoft.com>

TerryHowe reviewed Apr 13, 2023

View reviewed changes

Comment thread registry/remote/errop/errors.go Outdated

shizhMSFT approved these changes Apr 13, 2023

View reviewed changes

add examples

d8e4b0a

Signed-off-by: Billy Zha <jinzha1@microsoft.com>

shizhMSFT reviewed Apr 14, 2023

View reviewed changes

Comment thread registry/remote/referrers.go Outdated

Comment thread registry/remote/referrers.go Outdated

qweeah added 2 commits April 15, 2023 07:46

Make op private & add error validation wrapper

1484243

Signed-off-by: Billy Zha <jinzha1@microsoft.com>

doc clean

c83cd27

Signed-off-by: Billy Zha <jinzha1@microsoft.com>

TerryHowe mentioned this pull request Apr 19, 2023

Make errSkipDesc a publicly available error #487

Closed

qweeah added 2 commits April 23, 2023 15:50

resolve comments

2cd0040

Signed-off-by: Billy Zha <jinzha1@microsoft.com>

test clean

04c7cd5

Signed-off-by: Billy Zha <jinzha1@microsoft.com>

shizhMSFT reviewed Apr 24, 2023

View reviewed changes

Comment thread registry/remote/referrers.go

qweeah added 2 commits April 24, 2023 23:48

revert change

d6d6e28

Signed-off-by: Billy Zha <jinzha1@microsoft.com>

fix bug

e429f6c

Signed-off-by: Billy Zha <jinzha1@microsoft.com>

shizhMSFT approved these changes Apr 26, 2023

View reviewed changes

TerryHowe approved these changes Apr 26, 2023

View reviewed changes

Wwwsylvia reviewed Apr 27, 2023

View reviewed changes

Comment thread registry/remote/referrers.go Outdated

Comment thread registry/remote/example_test.go Outdated

qweeah added 3 commits April 27, 2023 03:07

resolve comments

88dd22a

Signed-off-by: Billy Zha <jinzha1@microsoft.com>

resolve comment

ee4d24f

Signed-off-by: Billy Zha <jinzha1@microsoft.com>

resolve comments

be342e1

Signed-off-by: Billy Zha <jinzha1@microsoft.com>

Wwwsylvia approved these changes Apr 27, 2023

View reviewed changes

Wwwsylvia merged commit b74a2a1 into oras-project:main Apr 27, 2023

Conversation

qweeah commented Apr 11, 2023

Uh oh!

codecov-commenter commented Apr 11, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

Uh oh!

Uh oh!

shizhMSFT left a comment

Choose a reason for hiding this comment

Uh oh!

sajayantony commented Apr 11, 2023

Uh oh!

TerryHowe left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

SteveLasker commented Apr 11, 2023

Uh oh!

qweeah commented Apr 12, 2023

Uh oh!

shizhMSFT left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

qweeah commented Apr 12, 2023

Uh oh!

sajayantony commented Apr 12, 2023

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

shizhMSFT left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

shizhMSFT left a comment

Choose a reason for hiding this comment

Uh oh!

TerryHowe left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Wwwsylvia left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

codecov-commenter commented Apr 11, 2023 •

edited

Loading

shizhMSFT left a comment •

edited

Loading