Skip to content

fix(gen-build-spec): handle errors gracefully when build tool is not supported#1303

Merged
behnazh-w merged 3 commits into
mainfrom
1302-bug---gen-build-spec-command-raises-an-error-when-the-build-tool-is-not-supported
Feb 17, 2026
Merged

fix(gen-build-spec): handle errors gracefully when build tool is not supported#1303
behnazh-w merged 3 commits into
mainfrom
1302-bug---gen-build-spec-command-raises-an-error-when-the-build-tool-is-not-supported

Conversation

@behnazh-w

@behnazh-w behnazh-w commented Feb 16, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

Summary

This PR improves error handling in the build spec generation process for unsupported build tools.

Description of changes

  • Previously, when an unsupported build tool was encountered during build spec generation, Macaron would raise an unhandled exception, resulting in unclear error messages and potential process failures. This update introduces explicit checks for unsupported build tools and handles such cases gracefully by providing clear, user-friendly error messages instead of stack traces.
  • Added unit tests to catch similar issues.

Related issues

Fixes #1302

@behnazh-w behnazh-w linked an issue Feb 16, 2026 that may be closed by this pull request
[Bug] - [gen-build-spec command raises an error when the build tool is not supported] #1302
Closed
@oracle-contributor-agreement oracle-contributor-agreement Bot added the OCA Verified All contributors have signed the Oracle Contributor Agreement. label Feb 16, 2026
@behnazh-w behnazh-w marked this pull request as ready for review February 17, 2026 00:51
AbhinavPradeep
AbhinavPradeep reviewed Feb 17, 2026
View reviewed changes
Comment thread src/macaron/build_spec_generator/common_spec/pypi_spec.py Outdated
@behnazh-w
fix(gen-build-spec): handle errors gracefully when build tool is not …
801dbd8 
…supported.

Signed-off-by: behnazh-w <behnaz.hassanshahi@oracle.com>
@behnazh-w
test: add unit tests
eb73c84 
Signed-off-by: behnazh-w <behnaz.hassanshahi@oracle.com>
@behnazh-w
chore: return an empty list when default build command cannot be found
f0e5a81 
Signed-off-by: behnazh-w <behnaz.hassanshahi@oracle.com>
@behnazh-w behnazh-w force-pushed the 1302-bug---gen-build-spec-command-raises-an-error-when-the-build-tool-is-not-supported branch from 6fedf13 to f0e5a81 Compare February 17, 2026 07:16
AbhinavPradeep
AbhinavPradeep approved these changes Feb 17, 2026
View reviewed changes

@AbhinavPradeep AbhinavPradeep left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@behnazh-w behnazh-w merged commit bf788f3 into main Feb 17, 2026
10 checks passed
@behnazh-w behnazh-w deleted the 1302-bug---gen-build-spec-command-raises-an-error-when-the-build-tool-is-not-supported branch April 8, 2026 08:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AbhinavPradeep AbhinavPradeep AbhinavPradeep approved these changes

Assignees

No one assigned

Labels

OCA Verified All contributors have signed the Oracle Contributor Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Bug] - [gen-build-spec command raises an error when the build tool is not supported]

2 participants

@behnazh-w @AbhinavPradeep