add blurb about recorder to golang tutorial and sample#6384
Merged
Conversation
b2df1db to
591c44c
Compare
Signed-off-by: jberkhahn <jaberkha@us.ibm.com>
591c44c to
79add35
Compare
Contributor
Author
|
yeah its the molecule sanity tests that are failing :/ |
Contributor
|
The molecule links should be fixed now along with the scorecard test issues. Going to close and reopen to kick the tests again and pick up the fixes. |
everettraven
approved these changes
May 23, 2023
everettraven
left a comment
Contributor
There was a problem hiding this comment.
Overall looks good to me, just a teeny nit (shouldn't block the merge)
| } | ||
| ``` | ||
|
|
||
| This recorder will be used within the reconcile method of the controller to emit events. |
Contributor
There was a problem hiding this comment.
Nit: Unless we are going to show the recorder being used in this tutorial I'd prefer if we just said:
Suggested change
| This recorder will be used within the reconcile method of the controller to emit events. | |
| The recorder can be used within the reconcile method of the controller to emit events. |
Contributor
|
closing and reopening to pickup more CI fixes |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #6314
Not 100% confident in the testdata edit, we'll see if this works.