Fixes to golang tutorial#6321
Merged
Merged
Conversation
Contributor
|
you might have to rebase this PR on master to get the molecule tests to pass, we had some stuff that was broken in those recently |
These fixes sync the examples with the code Signed-off-by: Dharmit Shah <shahdharmit@gmail.com>
rashmigottipati
approved these changes
Feb 28, 2023
rashmigottipati
left a comment
Member
There was a problem hiding this comment.
/lgtm
based off of discussion in comment
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the change:
$subject
Motivation for the change:
These fixes sync the examples with the code.
Fixes parts of #6314.
Checklist
If the pull request includes user-facing changes, extra documentation is required:
changelog/fragments(seechangelog/fragments/00-template.yaml)website/content/en/docs