Adds note about repo flag#6312
Merged
Merged
Conversation
everettraven
approved these changes
Feb 20, 2023
Member
|
@dharmit you might have to rebase against master (if you haven't done that already) for the molecule tests to pass. |
Signed-off-by: Dharmit Shah <shahdharmit@gmail.com>
Contributor
Author
|
Thanks, @rashmigottipati. I had forgotten to rebase this particular PR. :) |
Contributor
|
you also need to sign the commit with '-s' |
Contributor
Author
For a There are two commits in this PR, and both are signed off using Anyway, I'll amend the commit and force-push to see if that helps. |
Co-authored-by: Bryce Palmer <everettraven@gmail.com> Signed-off-by: Dharmit Shah <shahdharmit@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Dharmit Shah shahdharmit@gmail.com
Description of the change:
$subject
Motivation for the change:
To ensure that the reader doesn't get lost into trying to fix the errors reported by the IDE. GoLand reported 35 errors to me. I decided to see at the very first occurrence, which was in the
importblock. Luckily, for me, fixing that fixed all the subsequent errors.Checklist
If the pull request includes user-facing changes, extra documentation is required:
changelog/fragments(seechangelog/fragments/00-template.yaml)website/content/en/docs