set default goal since bingo disrupts it#1447
Merged
Merged
Conversation
Signed-off-by: Jordan <jordan@nimblewidget.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1447 +/- ##
=======================================
Coverage 48.47% 48.47%
=======================================
Files 136 136
Lines 12814 12814
=======================================
Hits 6212 6212
Misses 5561 5561
Partials 1041 1041 ☔ View full report in Codecov by Sentry. |
everettraven
approved these changes
Sep 10, 2024
joelanford
approved these changes
Sep 10, 2024
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: everettraven, grokspawn, joelanford The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the change:
set a default goal of
allfor the MakefileMotivation for the change:
since 7a1b8ec the
allgoal is no longer the first (and therefore default-by-default) goal. This explicitly makes it the default target again.Reviewer Checklist
/docs