Enhance search preference based routing for WRR#6834
Merged
gbbafna merged 2 commits intoopensearch-project:mainfrom Mar 30, 2023
Merged
Enhance search preference based routing for WRR#6834gbbafna merged 2 commits intoopensearch-project:mainfrom
gbbafna merged 2 commits intoopensearch-project:mainfrom
Conversation
Contributor
Gradle Check (Jenkins) Run Completed with:
|
7473ec0 to
d0ae3d8
Compare
Contributor
Gradle Check (Jenkins) Run Completed with:
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6834 +/- ##
============================================
+ Coverage 70.67% 70.68% +0.01%
- Complexity 59206 59212 +6
============================================
Files 4812 4812
Lines 283748 283764 +16
Branches 40916 40918 +2
============================================
+ Hits 200527 200575 +48
- Misses 66715 66730 +15
+ Partials 16506 16459 -47 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
Gradle Check (Jenkins) Run Completed with:
|
256ba08 to
dc9ab0d
Compare
Contributor
Gradle Check (Jenkins) Run Completed with:
|
Contributor
Gradle Check (Jenkins) Run Completed with:
|
55ef13d to
dc9ab0d
Compare
Contributor
Gradle Check (Jenkins) Run Completed with:
|
Contributor
Gradle Check (Jenkins) Run Completed with:
|
gbbafna
reviewed
Mar 28, 2023
Contributor
gbbafna
left a comment
There was a problem hiding this comment.
can we create an issue where we list out the problems which this PR is solving ?
Contributor
Author
@gbbafna i've created issues corresponding to this PR and updated description |
gbbafna
approved these changes
Mar 30, 2023
Contributor
Gradle Check (Jenkins) Run Completed with:
|
Signed-off-by: Varun Bansal <bansvaru@amazon.com>
Signed-off-by: Varun Bansal <bansvaru@amazon.com>
4be3054 to
0f7e026
Compare
Contributor
Gradle Check (Jenkins) Run Completed with:
|
Contributor
|
The backport to To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/backport-2.x
# Create a new branch
git switch --create backport/backport-6834-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 d8d6e7324adb4be088cab8e1fa5833e18ef19109
# Push it to GitHub
git push --set-upstream origin backport/backport-6834-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/backport-2.xThen, create a pull request where the |
linuxpi
added a commit
to linuxpi/OpenSearch
that referenced
this pull request
Mar 30, 2023
) Signed-off-by: Varun Bansal <bansvaru@amazon.com> (cherry picked from commit d8d6e73)
linuxpi
added a commit
to linuxpi/OpenSearch
that referenced
this pull request
Mar 30, 2023
) Signed-off-by: Varun Bansal <bansvaru@amazon.com> (cherry picked from commit d8d6e73)
linuxpi
added a commit
to linuxpi/OpenSearch
that referenced
this pull request
Mar 30, 2023
) Signed-off-by: Varun Bansal <bansvaru@amazon.com> (cherry picked from commit d8d6e73)
6 tasks
linuxpi
added a commit
to linuxpi/OpenSearch
that referenced
this pull request
Apr 3, 2023
) Signed-off-by: Varun Bansal <bansvaru@amazon.com> (cherry picked from commit d8d6e73)
linuxpi
added a commit
to linuxpi/OpenSearch
that referenced
this pull request
Apr 3, 2023
) Signed-off-by: Varun Bansal <bansvaru@amazon.com> (cherry picked from commit d8d6e73)
linuxpi
added a commit
to linuxpi/OpenSearch
that referenced
this pull request
Apr 3, 2023
) Signed-off-by: Varun Bansal <bansvaru@amazon.com> (cherry picked from commit d8d6e73)
gbbafna
pushed a commit
that referenced
this pull request
Apr 4, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Various enhancements to search preference for Weighed Round Robin shard routing
Issues Resolved
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.