Skip to content

SimplifyChainedAssertJAssertion drops method calls in replacement#629

Merged
timtebeek merged 3 commits intoopenrewrite:mainfrom
jtymes:simplify-assertj-loses-method
Oct 31, 2024
Merged

SimplifyChainedAssertJAssertion drops method calls in replacement#629
timtebeek merged 3 commits intoopenrewrite:mainfrom
jtymes:simplify-assertj-loses-method

Conversation

@jtymes
Copy link
Copy Markdown
Contributor

@jtymes jtymes commented Oct 31, 2024

What's changed?

What's your motivation?

Anything in particular you'd like reviewers to focus on?

Anyone you would like to review specifically?

Have you considered any alternatives or workarounds?

Any additional context

Checklist

  • I've added unit tests to cover both positive and negative cases
  • I've read and applied the recipe conventions and best practices
  • I've used the IntelliJ IDEA auto-formatter on affected files

@timtebeek timtebeek self-requested a review October 31, 2024 18:30
@timtebeek timtebeek marked this pull request as ready for review October 31, 2024 18:30
@timtebeek
Copy link
Copy Markdown
Member

Thanks for the help here @jtymes ! The failing test was really helpful in pinning this down; the fix was fairly straightforward from there on, so I've applied that just now. Thanks again!

@timtebeek timtebeek added bug Something isn't working assertj labels Oct 31, 2024
@timtebeek timtebeek merged commit 05a917e into openrewrite:main Oct 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

assertj bug Something isn't working

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

SimplifyChainedAssertJAssertion drops method call in replacement

2 participants