Remove throws from method that adopts assertThrows#564
Merged
Conversation
timtebeek
commented
Aug 8, 2024
Member
Author
|
Turns out we were overthinking this one; as we already replace the entire method body with |
Collaborator
|
I'm just thinking with the above, what if the method throws multiple checked exceptions, and assertThrows only catches one, even if it is wrapping the entire method body. I think in that case, the remaining checked exception are still valid, or still not? From my memory I remember only removing one checked exception from the method signature, and keeping one when doing the junit 4 to 5 migration, where there were multiple checked exceptions. |
Open
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What's your motivation?