Convert assertTrue(false, String) and assertFalse(true, String) with fail(String)#558
Convert assertTrue(false, String) and assertFalse(true, String) with fail(String)#558timtebeek merged 6 commits intoopenrewrite:mainfrom
assertTrue(false, String) and assertFalse(true, String) with fail(String)#558Conversation
|
Awesome start, thanks! Did you notice this comment in the issue?
I think we can keep the tests, and replace the recipes with just a couple lines in Refaster recipes. |
assertTrue(false, String) and assertFalse(true, String) with fail(String)
Must admit I skimmed over that part :) I will continue working on this next week and apply the proposed changes! |
timtebeek
left a comment
There was a problem hiding this comment.
Great to see! Let's merge the two separate test classes into a single AssertLiteralBooleanToFailRecipeTest, and within those I think we write a single test that covers all four cases from a single unit test that just has the four statements in one.
timtebeek
left a comment
There was a problem hiding this comment.
Neat addition; thanks @Laurens-W !
What's changed?
Add recipe to rewrite assertTrue(false, "message") and assertFalse(true, "message") to fail("message")
What's your motivation?
AssertTrue(false)tofail#464Anything in particular you'd like reviewers to focus on?
Test coverage
Anyone you would like to review specifically?
@timtebeek @timo-abele
Have you considered any alternatives or workarounds?
Any additional context
Checklist