Increased idempotency of EqualsAvoidsNull by avoiding too many swaps#496
Merged
Conversation
Contributor
|
nice to see this going on, thanks. |
There was a problem hiding this comment.
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (2)
src/main/java/org/openrewrite/staticanalysis/EqualsAvoidsNull.java:174
- Consider whether other constant expression types beyond J.Literal should be included in this check, as the current condition may not cover all cases where swapping should be avoided.
if (!(firstArgument instanceof J.Literal) && !(m.getSelect() instanceof J.Literal)) {
src/test/java/org/openrewrite/staticanalysis/EqualsAvoidsNullTest.java:599
- [nitpick] The parameter name '_null' might be confused with the actual null literal; consider renaming it to a more descriptive identifier.
public void bar(String _null) {
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What's changed?
Increasing the idempotency of
EqualsAvoidsNullrecipe. Specifically preventing thrashing between expressions likeFOO.equals(BAR)changed toBAR.equals(FOO)changed toFOO.equals(BAR), etc.The test code has been taken from #487 (kudos to @pankratz76).
What's your motivation?