Skip to content

Fix missing constructor argument issue#492

Merged
arodionov merged 2 commits into
mainfrom
fix-356
Apr 2, 2025
Merged

Fix missing constructor argument issue#492
arodionov merged 2 commits into
mainfrom
fix-356

Conversation

@arodionov

Copy link
Copy Markdown
Contributor

@github-project-automation github-project-automation Bot moved this to In Progress in OpenRewrite Apr 1, 2025
@arodionov arodionov self-assigned this Apr 1, 2025
- fixed issue #356
- added tests

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some suggestions could not be made:

  • src/main/java/org/openrewrite/staticanalysis/NoDoubleBraceInitialization.java
    • lines 21-21

@arodionov arodionov requested a review from jevanlingen April 1, 2025 16:01
@arodionov arodionov moved this from In Progress to Ready to Review in OpenRewrite Apr 1, 2025

@timtebeek timtebeek left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Love the simpler solution here.

@arodionov arodionov merged commit 7e5ec9f into main Apr 2, 2025
@arodionov arodionov deleted the fix-356 branch April 2, 2025 08:36
@github-project-automation github-project-automation Bot moved this from Ready to Review to Done in OpenRewrite Apr 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

2 participants