Added option to provide a custom FQN to AnnotateNullableMethods recipe#491
Merged
jevanlingen merged 6 commits intoApr 2, 2025
Merged
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
JohannisK
commented
Apr 1, 2025
jevanlingen
reviewed
Apr 2, 2025
jevanlingen
reviewed
Apr 2, 2025
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
jevanlingen
approved these changes
Apr 2, 2025
timtebeek
reviewed
Apr 3, 2025
Comment on lines
+54
to
+56
| "By default `org.jspecify.annotations.Nullable` is used, but through the `nullableAnnotationClass` option a custom annotation can be provided." + | ||
| "When providing a custom `nullableAnnotationClass` that annotation should be meta annotated with `@Target(TYPE_USE)`." + | ||
| "This recipe scans for methods that do not already have a `@Nullable` annotation and checks their return " + |
Member
There was a problem hiding this comment.
Would you mind adding a space after each of the end of line dots here? It's often forgotten, but when these strings get concatenated the missing spaces will make the docs hard to read.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What's changed?
Added option to provide a custom FQN to AnnotateNullableMethods recipe
What's your motivation?
As requested in
Anyone you would like to review specifically?
@jevanlingen
@Laurens-W
@greg-at-moderne