Skip to content

Update Module provided recipes to use the provided scope#725

Merged
timtebeek merged 1 commit into
openrewrite:mainfrom
cjobinabo:updateModuleProvidedRecipes
May 16, 2025
Merged

Update Module provided recipes to use the provided scope#725
timtebeek merged 1 commit into
openrewrite:mainfrom
cjobinabo:updateModuleProvidedRecipes

Conversation

@cjobinabo

@cjobinabo cjobinabo commented May 15, 2025

Copy link
Copy Markdown
Contributor

What's changed?

This pull request updates the previously submitted module-removed recipes to use the provided scope to ensure the module's dependencies are resolved at compile time.

What's your motivation?

Address issues with applications failing to compile as a result of the dependency removal.

Anything in particular you'd like reviewers to focus on?

Anyone you would like to review specifically?

Have you considered any alternatives or workarounds?

Any additional context

Checklist

  • I've added unit tests to cover both positive and negative cases
  • I've read and applied the recipe conventions and best practices
  • I've used the IntelliJ IDEA auto-formatter on affected files

@github-project-automation github-project-automation Bot moved this to In Progress in OpenRewrite May 15, 2025

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some suggestions could not be made:

  • src/main/resources/META-INF/rewrite/examples.yml
    • lines 3282-3281
    • lines 3328-3346

@timtebeek timtebeek left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the help! I think we should already have similar recipes for Gradle if needed, but I'll merge this increment to not have you blocked there.

@github-project-automation github-project-automation Bot moved this from In Progress to Ready to Review in OpenRewrite May 16, 2025
@timtebeek timtebeek merged commit 866b433 into openrewrite:main May 16, 2025
2 checks passed
@github-project-automation github-project-automation Bot moved this from Ready to Review to Done in OpenRewrite May 16, 2025
@cjobinabo

Copy link
Copy Markdown
Contributor Author

Haha @timtebeek, I read your comment initially confused because I made the necessary changes for Gradle yesterday. Then I checked the contents of this PR and saw that the change never actually got pushed to the remote branch despite my commit to the local branch. I'll open a new PR from this branch with the Gradle update.

@cjobinabo cjobinabo mentioned this pull request May 16, 2025
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

2 participants