Conversation
Replace guava Primitive asList with Arrays asList Replace guava newArrayListWithExpectedSize with Java new ArrayList<>(int)
timtebeek
reviewed
Aug 8, 2024
timtebeek
reviewed
Aug 8, 2024
…are nuances lost in this way of doing it Remove trailing whitespace
timtebeek
reviewed
Aug 8, 2024
timtebeek
reviewed
Aug 8, 2024
timtebeek
reviewed
Aug 8, 2024
timtebeek
reviewed
Aug 8, 2024
timtebeek
reviewed
Aug 8, 2024
Member
timtebeek
left a comment
There was a problem hiding this comment.
Good additions, thanks! Couple small pointers but then I think we should be good to merge.
Correct more white spacing Apply feedback to NoGuavaPrimitiveAsList
timtebeek
reviewed
Aug 8, 2024
timtebeek
approved these changes
Aug 8, 2024
Member
timtebeek
left a comment
There was a problem hiding this comment.
Great to see these additional cases covered and added to our NoGuava composite recipe.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What's changed?
Replace guava TreeMap with Java TreeMap
Replace guava Primitive asList with Arrays asList
What's your motivation?
Customer feedback about no guava recipes
Anything in particular you'd like reviewers to focus on?
Test coverage
Anyone you would like to review specifically?
@timtebeek
Have you considered any alternatives or workarounds?
Any additional context
Checklist