Ensure jakarta.annotation dependency is provided scope. Add/change tests#734
Merged
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
timtebeek
approved these changes
May 19, 2025
timtebeek
left a comment
Member
There was a problem hiding this comment.
Perfect, thanks a lot for the detailed analysis and quick turn around on this!
The comments I placed are nothing to worry about; figured since you had removed the unnecessary <?xml version="1.0" encoding="UTF-8"?> already I'd phase out the unnecessary attributes as well to keep the tests free from boilerplate. Definitely not a reflection on the quality of the work, as that's always 🙌🏻 👏🏻
timtebeek
approved these changes
May 19, 2025
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
compile#728What's changed?
Changes recipe that adds
jakarta.annotation-apito useprovidedscopeAnyone you would like to review specifically?
@timtebeek
Have you considered any alternatives or workarounds?
Discussed in #728 - considered fixing
AddDependencyorChangeDependency, but may not be the correct solution.Any additional context
I believe migrating from Java EE to Jakarta EE, it may be recommended to switch maven dependency scopes to
providedas the runtime environment likely provides the Jakarta EE APIs.Checklist