Skip to content

add systemd-nspawn to implementations.md#1272

Merged
kolyshkin merged 1 commit into
opencontainers:mainfrom
Artoria2e5:patch-1
Mar 10, 2025
Merged

add systemd-nspawn to implementations.md#1272
kolyshkin merged 1 commit into
opencontainers:mainfrom
Artoria2e5:patch-1

Conversation

@Artoria2e5

Copy link
Copy Markdown
Contributor

It's a bit awkward really, since that nspawn isn't the WHOLE repo on GitHub unlike the others...

@AkihiroSuda AkihiroSuda added this to the v1.2.1 (tentative) milestone Nov 29, 2024
@kolyshkin

Copy link
Copy Markdown
Contributor

AFAICS systemd-nspawn does not implement this spec.

@kolyshkin

Copy link
Copy Markdown
Contributor

AFAICS systemd-nspawn does not implement this spec.

Therefore this should be closed (unless I'm missing something).

@AkihiroSuda

Copy link
Copy Markdown
Member

AFAICS systemd-nspawn does not implement this spec.

Implements: https://github.com/systemd/systemd/blob/main/src/nspawn/nspawn-oci.c

@kolyshkin

Copy link
Copy Markdown
Contributor

My bad, indeed, systemd-nspawn implements --oci-bundle option since systemd v242.

@kolyshkin kolyshkin left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My bad, indeed, systemd-nspawn implements --oci-bundle option since systemd v242.

So it would be nice to mention the above option and the version number, otherwise LGTM.

@AkihiroSuda

Copy link
Copy Markdown
Member

mention the above option and the version number

ping @Artoria2e5

@kolyshkin

Copy link
Copy Markdown
Contributor

ping @Artoria2e5

@rata

rata commented Feb 12, 2025

Copy link
Copy Markdown
Member

It reads a bundle (config.json, rootfs, etc.) but it doesn't seem to implement any of the subcommands (like features, list, etc.) and IIRC it's not a full spec or at the very least is an old spec what it implements (I think the former, not the full spec, of some old version of the spec).

Comment thread implementations.md Outdated
@AkihiroSuda

Copy link
Copy Markdown
Member

Please squash the commits

@kolyshkin

Copy link
Copy Markdown
Contributor

@Artoria2e5 please squash the commits.

It's a bit awkward really, since that nspawn isn't the WHOLE repo on GitHub unlike the others...

Signed-off-by: Mingye Wang <arthur200126@gmail.com>
@Artoria2e5

Copy link
Copy Markdown
Contributor Author

Ah sorry! done.

@kolyshkin kolyshkin merged commit ea38318 into opencontainers:main Mar 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants