Skip to content

[1.3] go.mod: Delete exclude directives#4749

Merged
lifubang merged 1 commit intoopencontainers:release-1.3from
rata:release-1.3
Apr 29, 2025
Merged

[1.3] go.mod: Delete exclude directives#4749
lifubang merged 1 commit intoopencontainers:release-1.3from
rata:release-1.3

Conversation

@rata
Copy link
Copy Markdown
Member

@rata rata commented Apr 28, 2025

This is a backport of #4748 for the 1.3 branch.

We already have the indirect require for 1.17.3, that comes
opencontainers/cgroups[1]. That module requires that version as min, so
go can't use older versions. We can just remove the excludes.

There might be cases where people can use runc as a dependency and use
replace to override it (not sure, but probably). We were clear on what
our dependencies are, so we can sleep fine. In the unlikely case that
some project uses runc as a dependency and:

 * Uses a replace for cilium v0.17.x but not the latest patch release (0.17.3 is fixed)
 * they run with 32bits
 * and hit this (that didn't happen always on CI)
 * Ignore the changelog for 0.17.3 that mentions the buffer overflow on
   32 bits platforms[2].

In that case, if we have a bug report, we can point them to the right
place. But 0.17.3 was released for some months now (most people probably
update) and 0.18.0 was released recently. I wouldn't worry about someone
hitting this in real life.

Also, the excludes directives prevent go install from working, so let's
just remove them.

[1]: https://github.com/opencontainers/cgroups/blob/9657f5a18b8d60a0f39fbb34d0cb7771e28e6278/go.mod#L6
[2]: https://github.com/cilium/ebpf/releases/tag/v0.17.3

Signed-off-by: Rodrigo Campos <rodrigoca@microsoft.com>
(cherry picked from commit 67b8a68)
@rata rata added the backport/1.3-pr A backport PR to release-1.3 label Apr 28, 2025
@rata rata added this to the 1.3.0 milestone Apr 28, 2025
@rata rata requested review from cyphar and kolyshkin April 28, 2025 10:13
Copy link
Copy Markdown
Contributor

@kolyshkin kolyshkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lifubang lifubang merged commit 889b4bd into opencontainers:release-1.3 Apr 29, 2025
34 checks passed
@rata rata deleted the release-1.3 branch April 29, 2025 17:41
@rata rata restored the release-1.3 branch April 29, 2025 17:41
@rata rata deleted the release-1.3 branch April 29, 2025 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport/1.3-pr A backport PR to release-1.3

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants