[1.3] go.mod: Delete exclude directives#4749
Merged
lifubang merged 1 commit intoopencontainers:release-1.3from Apr 29, 2025
Merged
[1.3] go.mod: Delete exclude directives#4749lifubang merged 1 commit intoopencontainers:release-1.3from
lifubang merged 1 commit intoopencontainers:release-1.3from
Conversation
We already have the indirect require for 1.17.3, that comes opencontainers/cgroups[1]. That module requires that version as min, so go can't use older versions. We can just remove the excludes. There might be cases where people can use runc as a dependency and use replace to override it (not sure, but probably). We were clear on what our dependencies are, so we can sleep fine. In the unlikely case that some project uses runc as a dependency and: * Uses a replace for cilium v0.17.x but not the latest patch release (0.17.3 is fixed) * they run with 32bits * and hit this (that didn't happen always on CI) * Ignore the changelog for 0.17.3 that mentions the buffer overflow on 32 bits platforms[2]. In that case, if we have a bug report, we can point them to the right place. But 0.17.3 was released for some months now (most people probably update) and 0.18.0 was released recently. I wouldn't worry about someone hitting this in real life. Also, the excludes directives prevent go install from working, so let's just remove them. [1]: https://github.com/opencontainers/cgroups/blob/9657f5a18b8d60a0f39fbb34d0cb7771e28e6278/go.mod#L6 [2]: https://github.com/cilium/ebpf/releases/tag/v0.17.3 Signed-off-by: Rodrigo Campos <rodrigoca@microsoft.com> (cherry picked from commit 67b8a68)
lifubang
approved these changes
Apr 29, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a backport of #4748 for the 1.3 branch.