vendor: update github.com/cyphar/filepath-securejoin to v0.3.3#4421
Merged
lifubang merged 1 commit intoopencontainers:mainfrom Oct 1, 2024
Merged
vendor: update github.com/cyphar/filepath-securejoin to v0.3.3#4421lifubang merged 1 commit intoopencontainers:mainfrom
lifubang merged 1 commit intoopencontainers:mainfrom
Conversation
This fixes issues we had with spurious MkdirAll failures. Signed-off-by: Aleksa Sarai <cyphar@cyphar.com>
rata
approved these changes
Sep 30, 2024
Member
rata
left a comment
There was a problem hiding this comment.
LGTM, thanks! And thanks for having a changelog for this dep, it helps too :)
I guess you verified if this fixes the issue, right?
Member
Author
|
I verified that |
lifubang
approved these changes
Oct 1, 2024
Member
lifubang
left a comment
There was a problem hiding this comment.
LGTM
If there are some test cases for this issue and for "is the created directory empty" logic check, it will be more better, but I think we can add these tests in a new PR. Thanks.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes issues we had with spurious MkdirAll failures.
Fixes #4408
Signed-off-by: Aleksa Sarai cyphar@cyphar.com