[1.1] nsexec: Check for errors in write_log()#3721
[1.1] nsexec: Check for errors in write_log()#3721AkihiroSuda merged 1 commit intoopencontainers:release-1.1from
Conversation
|
Test failures are unrelated to runc code, it seems like a network issue: Will re push in a few minutes. |
9558066 to
a2076b4
Compare
|
Hmm, it seems that link is not working anymore. Tests might need to use a new URL :( |
|
#3701 (and the other PR it links to) 👀 |
|
@tianon do we need to backport that to 1.1, then? |
|
I'm not a maintainer, just a long time contributor 😅
If the 1.1 branch is going to be maintained/used though, it probably does
make sense to backport those CI fixes IMO.
|
|
@rata CI fixes were landed, please rebase. |
a2076b4 to
d5b1941
Compare
|
@kolyshkin thanks! Rebased 🤞 |
|
Grr, tests are not passing due to this unit test: |
d5b1941 to
90139d9
Compare
|
It seems to be a flaky test, now test pass fine! @kolyshkin should I open an issue for this flaky test? |
Yes please (I think this is the first time I am seeing this). |
Opened #3735 trying to attack this (although I'm still not quite sure how the failure happened, the fix makes sense overall). |
Looks like another rebasing is needed for |
First, check if strdup() fails and error out. While we are there, the else case was missing brackets, as we only need to check ret in the else case. Fix that too Signed-off-by: Rodrigo Campos <rodrigoca@microsoft.com> (cherry picked from commit 5ce511d)
90139d9 to
f6e2cd3
Compare
|
Done, all should be green now (fedora still running, the rest is green) |
This is a backport of #3712 for release 1.1 branch.
First, check if strdup() fails and error out.
While we are there, the else case was missing brackets, as we only need to check ret in the else case. Fix that too
Signed-off-by: Rodrigo Campos rodrigoca@microsoft.com
(cherry picked from commit 5ce511d)