feat(client): add ._request_id property to object responses#1078
Merged
RobertCraigie merged 3 commits intomasterfrom Sep 17, 2024
Merged
feat(client): add ._request_id property to object responses#1078RobertCraigie merged 3 commits intomasterfrom
RobertCraigie merged 3 commits intomasterfrom
Conversation
90f9edd to
0bef40a
Compare
athyuttamre
reviewed
Sep 16, 2024
| } | ||
|
|
||
| return Object.defineProperty(value, '_request_id', { | ||
| value: response.headers.get('x-request-id'), |
Contributor
There was a problem hiding this comment.
Will this error if the value doesn't exist, or return undefined?
Collaborator
Author
There was a problem hiding this comment.
it'll return undefined or null
athyuttamre
approved these changes
Sep 16, 2024
athyuttamre
reviewed
Sep 17, 2024
96a8bb5 to
01c6cbd
Compare
athyuttamre
approved these changes
Sep 17, 2024
Merged
SkinnnyJay
pushed a commit
to SkinnnyJay/openai-node
that referenced
this pull request
Sep 13, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
on the tin