Skip to content

Filter based on deprecation, stability, and annotations in signal JQ helpers#870

Merged
lquerel merged 2 commits into
open-telemetry:mainfrom
lmolkova:filter-attrs-and-signals
Aug 8, 2025
Merged

Filter based on deprecation, stability, and annotations in signal JQ helpers#870
lquerel merged 2 commits into
open-telemetry:mainfrom
lmolkova:filter-attrs-and-signals

Conversation

@lmolkova

@lmolkova lmolkova commented Aug 7, 2025

Copy link
Copy Markdown
Member

Fixes #847 - applies stability, deprecation, annotations filters to signals in JQ helper methods and to attribute references under them.

@lmolkova lmolkova requested a review from a team as a code owner August 7, 2025 02:27
Comment thread crates/weaver_forge/expected_output/test/span/cosmosdb.md
Comment thread defaults/jq/semconv.jq
@lmolkova

lmolkova commented Aug 7, 2025

Copy link
Copy Markdown
Member Author

@MrAlias, could you please take a look?

I assume you'd expect exclude_deprecated to apply to metric and metric attributes and members of enum attributes, right?

@codecov

codecov Bot commented Aug 7, 2025

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 77.7%. Comparing base (c7dc043) to head (f01e021).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@          Coverage Diff          @@
##            main    #870   +/-   ##
=====================================
  Coverage   77.7%   77.7%           
=====================================
  Files         76      76           
  Lines       5924    5924           
=====================================
  Hits        4603    4603           
  Misses      1321    1321           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Comment thread defaults/jq/semconv.jq
@MrAlias

MrAlias commented Aug 8, 2025

Copy link
Copy Markdown

@MrAlias, could you please take a look?

I assume you'd expect exclude_deprecated to apply to metric and metric attributes and members of enum attributes, right?

Yeah, that sounds ideal. 👍

@lquerel lquerel left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lquerel lquerel merged commit d6d830f into open-telemetry:main Aug 8, 2025
23 checks passed

@MrAlias MrAlias left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for the fix 😄

pellared added a commit to open-telemetry/opentelemetry-go that referenced this pull request Aug 12, 2025
- Remove temporary fix to filter out deprecated metrics (addressed in
open-telemetry/weaver#870)
- Handle empty briefs gracefully
- Handle empty attributes gracefully
- Regenerate v1.36.0 semconv to fix docs

[Weaver v0.17.0
release](https://github.com/open-telemetry/weaver/releases/tag/v0.17.0)

Follow up to #7163

---------

Co-authored-by: Robert Pająk <pellared@hotmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

The jq function semconv_signal does not filter deprecated

3 participants