Skip to content

docs: Usage section#851

Merged
jsuereth merged 4 commits into
open-telemetry:mainfrom
tombrk:tombrk/docs
Aug 6, 2025
Merged

docs: Usage section#851
jsuereth merged 4 commits into
open-telemetry:mainfrom
tombrk:tombrk/docs

Conversation

@tombrk

@tombrk tombrk commented Jul 18, 2025

Copy link
Copy Markdown
Member

I wrote the usage section I hoped would have been there when I started using Weaver.

I focused on describing the core concepts and functionality involved when using Weaver to generate code, which imo is the most likely thing someone will attempt first in their schematized telemetry journey.

The new Usage section of the README consolidates the previous documentation section with added docs in such a way that introduced concepts build onto each other.

I did not aim for completeness. Existing reference documentation is just fine, but is now hopefully more easily approachable for newcomers

I wrote the usage section I hoped would have been there when I started
using Weaver.

I focused on describing the core concepts and functionality involved
when using Weaver to generate code, which imo is the most likely thing
someone will attempt first in their schematized telemetry journey.

The new Usage section of the README consolidates the previous
documentation section with added docs in such a way that introduced concepts build
onto each other.

I did not aim for completeness. Existing reference documentation is just
fine, but is now hopefully more easily approachable for newcomers
@tombrk tombrk requested a review from a team as a code owner July 18, 2025 14:43
@codecov

codecov Bot commented Jul 18, 2025

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 77.0%. Comparing base (11a9f82) to head (62b4f87).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@          Coverage Diff          @@
##            main    #851   +/-   ##
=====================================
  Coverage   76.9%   77.0%           
=====================================
  Files         76      76           
  Lines       5768    5768           
=====================================
+ Hits        4441    4442    +1     
+ Misses      1327    1326    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jsuereth jsuereth left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really love this PR!

Definitely love the documentation around how template generation works. I would like to preserve some of the existing references, but I think this is overall another big improvement like the previous one from @jerbly.

Comment thread README.md
Comment thread docs/validate.md Outdated

@lquerel lquerel left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much for these improvements to the documentation!

In my opinion, there are a few minor changes to be made that I have noted in my comments. Apart from these points to address, I think this PR is ready to go.

Comment thread README.md
Comment thread docs/codegen.md Outdated
Comment thread docs/codegen.md Outdated
Comment thread docs/validate.md Outdated
@tombrk

tombrk commented Jul 31, 2025

Copy link
Copy Markdown
Member Author

@jsuereth @lquerel fixed!

@jsuereth jsuereth enabled auto-merge (squash) August 6, 2025 00:47
@jsuereth jsuereth merged commit 9249854 into open-telemetry:main Aug 6, 2025
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants