Skip to content

fix(#69): add new class annotations to deprecated classes#89

Merged
jack-berg merged 12 commits intoopen-telemetry:mainfrom
cboudereau:main
Oct 9, 2024
Merged

fix(#69): add new class annotations to deprecated classes#89
jack-berg merged 12 commits intoopen-telemetry:mainfrom
cboudereau:main

Conversation

@cboudereau
Copy link
Copy Markdown
Contributor

@cboudereau cboudereau commented Sep 17, 2024

fixes #69

@cboudereau cboudereau requested a review from a team September 17, 2024 16:18
@linux-foundation-easycla
Copy link
Copy Markdown

linux-foundation-easycla bot commented Sep 17, 2024 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

@cboudereau cboudereau marked this pull request as draft September 19, 2024 14:40
@cboudereau cboudereau marked this pull request as ready for review September 23, 2024 09:26
@cboudereau cboudereau requested a review from a team as a code owner September 23, 2024 09:26
@cboudereau
Copy link
Copy Markdown
Contributor Author

cboudereau commented Sep 23, 2024

Hi,

I think the PR is done.

I used @see instead of @link since the moved classes are in another jar which is not referenced.

trask
trask reviewed Sep 23, 2024
View reviewed changes
Comment thread semconv/src/main/java/io/opentelemetry/semconv/ResourceAttributes.java Outdated
@cboudereau
Copy link
Copy Markdown
Contributor Author

cboudereau commented Sep 24, 2024 •
edited
Loading

Hi @trask , it should be ok but the markdown link check failed because all "maven-badges.herokuapp.com" badges are down.

This is a problem related to maven-badges.herokuapp.com itself though.

trask
trask reviewed Sep 24, 2024
View reviewed changes
Comment thread semconv/src/main/java/io/opentelemetry/semconv/ResourceAttributes.java Outdated
trask
trask reviewed Sep 24, 2024
View reviewed changes
Comment thread semconv/src/main/java/io/opentelemetry/semconv/ResourceAttributes.java
Comment thread semconv/src/main/java/io/opentelemetry/semconv/ResourceAttributes.java
@cboudereau
Copy link
Copy Markdown
Contributor Author

cboudereau commented Sep 26, 2024

Hi @trask, I updated the PR to merge the recent changes from #83. It should be ok 👍

trask
trask reviewed Sep 26, 2024
View reviewed changes
Comment thread semconv/src/main/java/io/opentelemetry/semconv/ResourceAttributes.java Outdated
@cboudereau @trask
Update semconv/src/main/java/io/opentelemetry/semconv/ResourceAttribu…
79edb28 
…tes.java

Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com>
trask
trask approved these changes Sep 26, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@trask trask left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@cboudereau
Copy link
Copy Markdown
Contributor Author

cboudereau commented Sep 26, 2024

thanks!

I am not authorized to merge though.

@trask
Copy link
Copy Markdown
Member

trask commented Sep 26, 2024

it will need to be merged by one of the @open-telemetry/java-maintainers

@jack-berg
Copy link
Copy Markdown
Member

jack-berg commented Oct 9, 2024

Sorry about the delay. Thanks!

@jack-berg jack-berg merged commit e1254cf into open-telemetry:main Oct 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@trask trask trask approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Decorate deprecations with suggested replacements

3 participants

@cboudereau @trask @jack-berg