Skip to content

Update to semantic-conventions 1.26.0#73

Merged
jack-berg merged 8 commits intoopen-telemetry:mainfrom
crossoverJie:semconv-1.26.0
Jul 1, 2024
Merged

Update to semantic-conventions 1.26.0#73
jack-berg merged 8 commits intoopen-telemetry:mainfrom
crossoverJie:semconv-1.26.0

Conversation

@crossoverJie
Copy link
Copy Markdown
Member

Update to semantic-conventions 1.26.0

@crossoverJie crossoverJie requested a review from a team June 3, 2024 15:20
*
* @deprecated Deprecated, use `messaging.client.id` instead.
*/
@Deprecated
Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Due to duplicate variable names, CI cannot pass😂.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you could work around this by adding

  {# deprecated messaging.client_id clashes with messaging.client.id #}
  {%- if attribute.fqn != "messaging.client_id" %}

to

{% set attribute_const_name = attribute.fqn | to_const_name -%}

@lmolkova is there a better solution for this?

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

check out open-telemetry/semantic-conventions#1031 and open-telemetry/semantic-conventions#1118

we may want to go ahead and implement option 2 from open-telemetry/semantic-conventions#1118 (but wait to merge it until that proposal is finalized)

I've added topic to today's Java SIG meeting to discuss

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See #75 - we'll provide build-tool fix ASAP as we have a concensus

Copy link
Copy Markdown
Member

@lmolkova lmolkova Jun 12, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here's the change that drops problematic attribute - crossoverJie#1 (if Java SIG will accept it as a mitigation)

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here's the change that drops problematic attribute - crossoverJie#1 (if Java SIG will accept it as a mitigation)

Thank you for your work on this issue.

Liudmila Molkova and others added 2 commits June 12, 2024 09:14
@crossoverJie crossoverJie requested review from laurit and trask June 13, 2024 08:03
@crossoverJie crossoverJie requested a review from lmolkova June 21, 2024 02:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants