Update LogRecord API to set and make use of context to set trace id / span id / trace flags,#4668
Merged
lzchen merged 4 commits intoopen-telemetry:mainfrom Jul 9, 2025
Conversation
Contributor
Author
|
@emdneto @tammy-baylis-swi can I get your thoughts/reviews on this PR ? |
Contributor
|
I think this is good. It's safer than changing the |
emdneto
approved these changes
Jul 8, 2025
…rd' of github.com:DylanRussell/opentelemetry-python into add_context_to_logrecord
pmcollins
reviewed
Jul 8, 2025
pmcollins
approved these changes
Jul 9, 2025
1 task
JWinermaSplunk
pushed a commit
to JWinermaSplunk/opentelemetry-python
that referenced
this pull request
Feb 17, 2026
… span id / trace flags, (open-telemetry#4668)
JWinermaSplunk
pushed a commit
to JWinermaSplunk/opentelemetry-python
that referenced
this pull request
Feb 17, 2026
… span id / trace flags, (open-telemetry#4668)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Basically just a continuation of #4597. My PR just updates the API LogRecord to match what the SDK LogRecord does with context..
This will help me migrate instrumentations using the API Event to use the API LogRecord,.. I ran into an issue migrating one of the instrumentations that relies on
EventsLogger.emitgetting the context and using it to set trace/spanid: https://github.com/open-telemetry/opentelemetry-python/blob/main/opentelemetry-sdk/src/opentelemetry/sdk/_events/__init__.py#L52There is no equivalent logic in the
Logger, but this PR adds it..Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Unit tests
Does This PR Require a Contrib Repo Change?
Checklist: