Make a BatchProcessor class which both BatchSpanRecordProcessor and BatchLogRecordProcessor can use#4562
Merged
aabmass merged 36 commits intoopen-telemetry:mainfrom May 12, 2025
Merged
Conversation
…-python into refactor_blrp
xrmx
reviewed
Apr 29, 2025
opentelemetry-sdk/tests/shared_internal/test_batch_processor.py
Outdated
Show resolved
Hide resolved
xrmx
reviewed
Apr 30, 2025
Contributor
Author
|
Nevermind.. was able to get the test working |
xrmx
approved these changes
May 6, 2025
aabmass
reviewed
May 8, 2025
Member
aabmass
left a comment
There was a problem hiding this comment.
Nice, just a few comments on design and typing
opentelemetry-sdk/src/opentelemetry/sdk/_shared_internal/__init__.py
Outdated
Show resolved
Hide resolved
opentelemetry-sdk/src/opentelemetry/sdk/_shared_internal/__init__.py
Outdated
Show resolved
Hide resolved
opentelemetry-sdk/src/opentelemetry/sdk/_shared_internal/__init__.py
Outdated
Show resolved
Hide resolved
opentelemetry-sdk/src/opentelemetry/sdk/_logs/_internal/export/__init__.py
Outdated
Show resolved
Hide resolved
lzchen
approved these changes
May 12, 2025
…nto refactor_blrp
aabmass
approved these changes
May 12, 2025
opentelemetry-sdk/src/opentelemetry/sdk/_shared_internal/__init__.py
Outdated
Show resolved
Hide resolved
mxiamxia
pushed a commit
to aws-observability/aws-otel-python-instrumentation
that referenced
this pull request
Oct 30, 2025
…58b0 (#524) This PR updates the upstream OpenTelemetry Python dependency to its September 2025 release; Upgrading from version 1.33.1/0.54b1 to 1.37.0/0.58b0. It also resolves several conflicts between the following OTel PRs and existing ADOT patches: starlette: Remove maximum version constraint open-telemetry/opentelemetry-python-contrib#3456 Make a BatchProcessor class which both BatchSpanRecordProcessor and BatchLogRecordProcessor can use open-telemetry/opentelemetry-python#4562 Make exporter timeout encompass retries/backoffs, add jitter to backoffs, cleanup code a bit open-telemetry/opentelemetry-python#4564 Update BatchSpanProcessor to use new BatchProcessor class open-telemetry/opentelemetry-python#4580 Fix issue where deadlock can occur over logging._lock open-telemetry/opentelemetry-python#4636 Tests Performed tox -e lint tox -e spellcheck tox -e 3.9-test-aws-opentelemetry-distro tox -e 3.10-test-aws-opentelemetry-distro tox -e 3.11-test-aws-opentelemetry-distro tox -e 3.12-test-aws-opentelemetry-distro tox -e 3.13-test-aws-opentelemetry-distro Smoke/contract tests: ./gradlew appsignals-tests:contract-tests:contractTests By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
liustve
added a commit
to aws-observability/aws-otel-python-instrumentation
that referenced
this pull request
Feb 4, 2026
Automated update of OpenTelemetry dependencies. **Build Status:** ❌ [failure](https://github.com/aws-observability/aws-otel-python-instrumentation/actions/runs/21465140126) **Updated versions:** - [OpenTelemetry Python](https://github.com/open-telemetry/opentelemetry-python/releases/tag/v1.39.1): 1.39.1 - [OpenTelemetry Contrib](https://github.com/open-telemetry/opentelemetry-python-contrib/releases/tag/v0.60b1): 0.60b1 - [opentelemetry-sdk-extension-aws](https://pypi.org/project/opentelemetry-sdk-extension-aws/2.1.0/): 2.1.0 - [opentelemetry-propagator-aws-xray](https://pypi.org/project/opentelemetry-propagator-aws-xray/1.0.2/): 1.0.2 **Upstream releases with breaking changes:** Note: the mechanism to detect upstream breaking changes is not perfect. Be sure to check all new releases and understand if any additional changes need to be addressed. **opentelemetry-python:** - [Version 1.35.0/0.56b0](https://github.com/open-telemetry/opentelemetry-python/releases/tag/v1.35.0) **opentelemetry-python-contrib:** - [Version 1.34.0/0.55b0](https://github.com/open-telemetry/opentelemetry-python-contrib/releases/tag/v0.55b0) *Description of changes:* - Un-reverts changes done in this PR: #531 - Removed patches for Bedrock following the changes applied in these PRs: open-telemetry/opentelemetry-python-contrib#3544, open-telemetry/opentelemetry-python-contrib#3548, open-telemetry/opentelemetry-python-contrib#3875, open-telemetry/opentelemetry-python-contrib#3990 - Removes patches for Secrets Manager, SNS, and Step Functions following the changes applied in these PRs: open-telemetry/opentelemetry-python-contrib#3734, open-telemetry/opentelemetry-python-contrib#3737, open-telemetry/opentelemetry-python-contrib#3765, - Removes patches for Starlette following the changes applied in this PR: open-telemetry/opentelemetry-python-contrib#3456 - Changes imports and implementation of `OTLPAwsLogExporter`, `AwsCloudWatchOtlpBatchLogRecordProcessor`, and `CompactConsoleLogExporter` following these PRs: open-telemetry/opentelemetry-python#4580, open-telemetry/opentelemetry-python#4535, open-telemetry/opentelemetry-python#4562, open-telemetry/opentelemetry-python#4647, open-telemetry/opentelemetry-python#4676 - Removes a few AWS semantic conventions from `_aws_attribute_keys ` and replaces them with equivalent ones from upstream following the changes in this PR: open-telemetry/opentelemetry-python#4791 - Fix Lambda instrumentation test to set `AWS_LAMBDA_FUNCTION_NAME` env var following changes in: open-telemetry/opentelemetry-python-contrib#3183 - Adds a few more contract tests to verify upstream's botocore instrumentation library By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice. --------- Co-authored-by: github-actions <github-actions@github.com> Co-authored-by: Thomas Pierce <thp@amazon.com> Co-authored-by: Steve Liu <liustve@amazon.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Make a
BatchProcessorclass which bothBatchSpanRecordProcessorandBatchLogRecordProcessorcan use.Move
BatchProcessorinto a new_shared_internalfolder in the SDK, so both processors can make use of it.In a follow up PR, I will update
BatchSpanRecordProcessorto use this new class.Fixes # (issue)
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Added unit tests
Does This PR Require a Contrib Repo Change?
Checklist: