Skip to content

sdk: remove duplicated env vars#4491

Merged
xrmx merged 3 commits intoopen-telemetry:mainfrom
emdneto:pyright-sdkenv
Mar 20, 2025
Merged

sdk: remove duplicated env vars#4491
xrmx merged 3 commits intoopen-telemetry:mainfrom
emdneto:pyright-sdkenv

Conversation

@emdneto
Copy link
Member

@emdneto emdneto commented Mar 18, 2025

Running pyright at sdk/environment_variables:

__init__.py:568:1 - error: "OTEL_EXPORTER_OTLP_METRICS_ENDPOINT" is constant (because it is uppercase) and cannot be redefined (reportConstantRedefinition)
__init__.py:577:1 - error: "OTEL_EXPORTER_OTLP_METRICS_CERTIFICATE" is constant (because it is uppercase) and cannot be redefined (reportConstantRedefinition)
__init__.py:595:1 - error: "OTEL_EXPORTER_OTLP_METRICS_HEADERS" is constant (because it is uppercase) and cannot be redefined (reportConstantRedefinition)
__init__.py:603:1 - error: "OTEL_EXPORTER_OTLP_METRICS_TIMEOUT" is constant (because it is uppercase) and cannot be redefined (reportConstantRedefinition)
__init__.py:619:1 - error: "OTEL_EXPORTER_OTLP_METRICS_COMPRESSION" is constant (because it is uppercase) and cannot be redefined (reportConstantRedefinition)
__init__.py:717:1 - error: "OTEL_EXPORTER_OTLP_METRICS_CLIENT_KEY" is constant (because it is uppercase) and cannot be redefined (reportConstantRedefinition)
__init__.py:740:1 - error: "OTEL_EXPORTER_OTLP_METRICS_CLIENT_CERTIFICATE" is constant (because it is uppercase) and cannot be redefined (reportConstantRedefinition)

@emdneto
remove duplicated env vars from sdk
a6a47aa 
Signed-off-by: emdneto <9735060+emdneto@users.noreply.github.com>
@emdneto emdneto requested a review from a team as a code owner March 18, 2025 02:22
@emdneto emdneto moved this to Easy to review / merge / close in Python PR digest Mar 18, 2025
@emdneto emdneto added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Mar 18, 2025
@pmcollins
Copy link
Member

pmcollins commented Mar 18, 2025

Hi Emídio -- LGTM but would this be considered a breaking change?

@emdneto emdneto removed the Skip Changelog PRs that do not require a CHANGELOG.md entry label Mar 18, 2025
@emdneto
Copy link
Member Author

emdneto commented Mar 18, 2025 •
edited
Loading

Hi Emídio -- LGTM but would this be considered a breaking change?

Hmm, I double-checked each variable, and they have the same name/value. You will still be able to import them. We can changelog it with Removed: if you want

@pmcollins
Copy link
Member

pmcollins commented Mar 18, 2025

Hi Emídio -- LGTM but would this be considered a breaking change?

Hmm, I double-checked each variable, and they have the same name/value. You will still be able to import it. We can changelog it with Removed: if you want

Oh sorry, it's fine -- I didn't realize the duplicates were in the same file.

@emdneto emdneto added the Approve Public API check This label shows that the public symbols added or changed in a PR are strictly necessary label Mar 18, 2025
@emdneto
add changelog
38374d8 
Signed-off-by: emdneto <9735060+emdneto@users.noreply.github.com>
@xrmx xrmx merged commit 829fcc5 into open-telemetry:main Mar 20, 2025
385 checks passed
@github-project-automation github-project-automation bot moved this from Easy to review / merge / close to Done in Python PR digest Mar 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@xrmx xrmx xrmx approved these changes

@pmcollins pmcollins pmcollins approved these changes

@lzchen lzchen lzchen approved these changes

Assignees

No one assigned

Labels

Approve Public API check This label shows that the public symbols added or changed in a PR are strictly necessary

Projects

Python PR digest
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@emdneto @pmcollins @xrmx @lzchen