opentelemetry-sdk: fix OTLP exporting of histogram explicit buckets advisory#4434
Merged
xrmx merged 3 commits intoopen-telemetry:mainfrom Feb 18, 2025
Merged
opentelemetry-sdk: fix OTLP exporting of histogram explicit buckets advisory#4434xrmx merged 3 commits intoopen-telemetry:mainfrom
xrmx merged 3 commits intoopen-telemetry:mainfrom
Conversation
…dvisory OTLP exporters don't rely on the default aggregation for histogram instead they do it explicitly. So instead of setting boundaries at init time of ExplicitBucketHistogramAggregation delay it in _create_aggregation when we have the Histogram at hand. Co-authored-by: Emídio Neto <9735060+emdneto@users.noreply.github.com>
emdneto
approved these changes
Feb 17, 2025
Member
emdneto
left a comment
There was a problem hiding this comment.
The added test fails in main. Also, test_view_overrides_buckets is passing, so all good.
emdneto
reviewed
Feb 17, 2025
Co-authored-by: Emídio Neto <9735060+emdneto@users.noreply.github.com>
aabmass
approved these changes
Feb 18, 2025
xrmx
added a commit
to xrmx/opentelemetry-python
that referenced
this pull request
Feb 21, 2025
…dvisory (open-telemetry#4434) OTLP exporters don't rely on the default aggregation for histogram instead they do it explicitly. So instead of setting boundaries at init time of ExplicitBucketHistogramAggregation delay it in _create_aggregation when we have the Histogram at hand. Co-authored-by: Emídio Neto <9735060+emdneto@users.noreply.github.com>
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
OTLP exporters don't rely on the default aggregation for histogram instead they create one explicitly. So instead of setting boundaries at init time of ExplicitBucketHistogramAggregation delay it in _create_aggregation when we have the Histogram at hand.
Fixes #4428
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Does This PR Require a Contrib Repo Change?
Checklist: