Disconnect gRPC client stub when shutting down OTLPSpanExporter#4370
Disconnect gRPC client stub when shutting down OTLPSpanExporter#4370xrmx merged 11 commits intoopen-telemetry:mainfrom
Conversation
|
@xmakro Thanks for the PR, please add a CHANGELOG entry. Can this be tested? |
|
I added the change log. I don't see a good way to test the disconnect, since it is the gRPC channel that gets disconnected, but these channels are not exposed on the gRPC server side api. |
...pentelemetry-exporter-otlp-proto-grpc/src/opentelemetry/exporter/otlp/proto/grpc/exporter.py
Outdated
Show resolved
Hide resolved
|
@xmakro, do you have time to look into these failures? Or do you mind if I branch and take a stab? |
|
The checks report a ruff error. I synced this branch to head, updated ruff and ran the pre-commit and cannot reproduce this error. I'm happy if you can fix this by branching. |
|
@xmakro, I was able to reproduce what the linter here was failing on. https://github.com/xmakro/opentelemetry-python/pull/1 Maybe your ruff settings are set a bit different? |
|
@xmakro just checking in here. Does the PR I sent to your fork make sense. Thanks! |
Ruff Reformat For GRPC Stub
|
Looks great, thanks! I merged your PR |
|
Nice thank you! @xmakro |
Signed-off-by: emdneto <9735060+emdneto@users.noreply.github.com>
Otherwise the gRPC client will stay connected past the shutdown
Fixes #4429