Skip to content

Adjust deprecation warning in LogRecord to also use deprecated decorator#4664

Merged
aabmass merged 3 commits intoopen-telemetry:mainfrom
emdneto:add-deprecation-warning
Jul 2, 2025
Merged

Adjust deprecation warning in LogRecord to also use deprecated decorator#4664
aabmass merged 3 commits intoopen-telemetry:mainfrom
emdneto:add-deprecation-warning

Conversation

@emdneto
Copy link
Member

@emdneto emdneto commented Jul 1, 2025

Discussed offline with @aabmass and @tammy-baylis-swi :

We keep the warning mechanism and also add the decorator on the deprecated overload
reason: By using the deprecated decorator, typecheckers like pyright should still alert the user that it's deprecated.

@emdneto emdneto requested a review from a team as a code owner July 1, 2025 23:31
@emdneto emdneto added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Jul 1, 2025
@xrmx xrmx moved this to Easy to review / merge / close in Python PR digest Jul 2, 2025
@aabmass aabmass merged commit 43341d7 into open-telemetry:main Jul 2, 2025
470 of 472 checks passed
@github-project-automation github-project-automation bot moved this from Easy to review / merge / close to Done in Python PR digest Jul 2, 2025
@tammy-baylis-swi
Copy link
Contributor

Thank you Emídio!

JWinermaSplunk pushed a commit to JWinermaSplunk/opentelemetry-python that referenced this pull request Feb 17, 2026
…tor (open-telemetry#4664)

* Adjust deprecation warning in LogRecord to also use deprecated decorator

* fix
JWinermaSplunk pushed a commit to JWinermaSplunk/opentelemetry-python that referenced this pull request Feb 17, 2026
…tor (open-telemetry#4664)

* Adjust deprecation warning in LogRecord to also use deprecated decorator

* fix
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Skip Changelog PRs that do not require a CHANGELOG.md entry

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

4 participants