fix(otlp-exporter-base): handle response error event #6412
Merged
pichlermarc merged 6 commits intoopen-telemetry:mainfrom Feb 24, 2026
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #6412 +/- ##
==========================================
+ Coverage 95.59% 95.68% +0.09%
==========================================
Files 361 364 +3
Lines 11595 11782 +187
Branches 2683 2745 +62
==========================================
+ Hits 11084 11274 +190
+ Misses 511 508 -3
🚀 New features to boost your workflow:
|
…aders are received but socket is closed before request finishes
87232d1 to
13b3bc4
Compare
cjihrig
reviewed
Feb 16, 2026
9947056 to
37968e5
Compare
trentm
approved these changes
Feb 20, 2026
| res.socket?.destroy(); | ||
| }); | ||
| }); | ||
| server.listen(8080); |
Contributor
There was a problem hiding this comment.
nit: Hardcoding a port could collide with something in use.
Member
Author
There was a problem hiding this comment.
yep; I also noticed that when working on it. I must've done that when I initially wrote the tests - I've opted to leave this as-is for now to avoid blowing up the diff. I'll do another pass to address this after it's merged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
See #6410, the error event on the response is unhandled, it may be triggered in certain cases, like the author describes. This PR fixes this by adding a test + handling the response. In these cases we should already have the headers, so I added handling for sucess/failure/retry based on that, even if the response was not fully received (since the response is not necessary to ensure the OTLP export remains functional)
Fixes #6410
Type of change
How Has This Been Tested?