fix(core): Avoid using DOM types for otperformance export#6278
Merged
pichlermarc merged 4 commits intoopen-telemetry:mainfrom Jan 14, 2026
Merged
fix(core): Avoid using DOM types for otperformance export#6278pichlermarc merged 4 commits intoopen-telemetry:mainfrom
pichlermarc merged 4 commits intoopen-telemetry:mainfrom
Conversation
1 task
c871bfc to
964b006
Compare
pichlermarc
reviewed
Jan 12, 2026
Member
pichlermarc
left a comment
There was a problem hiding this comment.
Hi @samchungy thanks for reaching out and reporting this.
I'd like to suggest using a type definition we had used previously for this, see comment below.
Co-authored-by: pichlermarc <pichlermarc@users.noreply.github.com>
964b006 to
4fae1b4
Compare
Member
|
Thanks! Please also add a changelog entry in |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #6278 +/- ##
=======================================
Coverage 95.39% 95.39%
=======================================
Files 316 316
Lines 9558 9558
Branches 2210 2210
=======================================
Hits 9118 9118
Misses 440 440 🚀 New features to boost your workflow:
|
2 tasks
pichlermarc
reviewed
Jan 14, 2026
pichlermarc
reviewed
Jan 14, 2026
pichlermarc
approved these changes
Jan 14, 2026
Contributor
|
Thank you for your contribution @samchungy! 🎉 We would like to hear from you about your experience contributing to OpenTelemetry by taking a few minutes to fill out this survey. |
maryliag
pushed a commit
to maryliag/opentelemetry-js
that referenced
this pull request
Jan 15, 2026
…etry#6278) Co-authored-by: pichlermarc <pichlermarc@users.noreply.github.com> Co-authored-by: Marc Pichler <marc.pichler@dynatrace.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
This PR introduced a change which requires users to use DOM types or use skipLibCheck
Example in our CI failing:
https://github.com/seek-oss/skuba/actions/runs/20899166995/job/60042387974?pr=2202#step:5:562
Fixes # (issue)
Short description of the changes
Explicitly types the
optperformanceexport to avoid referencing DOM typesType of change
Please delete options that are not relevant.
How Has This Been Tested?
Locally
Checklist: