Skip to content

refactor(sdk-trace-node): Use tree-shakeable string constants for semconv#4748

Merged
pichlermarc merged 3 commits intoopen-telemetry:mainfrom
JohannesHuster:sdk-trace-node-semconv
Jun 3, 2024
Merged

refactor(sdk-trace-node): Use tree-shakeable string constants for semconv#4748
pichlermarc merged 3 commits intoopen-telemetry:mainfrom
JohannesHuster:sdk-trace-node-semconv

Conversation

@JohannesHuster
Copy link
Copy Markdown
Contributor

@JohannesHuster JohannesHuster commented Jun 1, 2024

Which problem is this PR solving?

Updates #4567

Short description of the changes

Replace deprecated imports from @opentelemetry/semantic-conventions with new (tree-shakeable) string constants for package @opentelemetry/sdk-trace-node. What I did:

  • Search for “@opentelemetry/semantic-conventions” in package path.
    • Add new imports and check that new and old strings match exactly.
    • Use new imports and remove old ones.

Type of change

  • Bug fix (non-breaking change which fixes an issue) (refactor)

How Has This Been Tested?

  • npm test

Checklist:

  • Followed the style guidelines of this project
  • Unit tests have been added
    • No new functionality
  • Documentation has been updated

@JohannesHuster JohannesHuster marked this pull request as ready for review June 1, 2024 16:40
@JohannesHuster JohannesHuster requested a review from a team June 1, 2024 16:40
pichlermarc
pichlermarc approved these changes Jun 3, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@pichlermarc pichlermarc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thx 🙂

@pichlermarc pichlermarc added this pull request to the merge queue Jun 3, 2024
Merged via the queue into open-telemetry:main with commit 7e72f1c Jun 3, 2024
@pichlermarc pichlermarc mentioned this pull request Jun 3, 2024
Merged
@JohannesHuster JohannesHuster deleted the sdk-trace-node-semconv branch June 3, 2024 17:29
@JamieDanielson JamieDanielson mentioned this pull request Jun 3, 2024
Closed
24 tasks
This was referenced Jun 27, 2024
Merged
Merged
Merged
@AlexOnyi AlexOnyi mentioned this pull request Jun 30, 2024
Open
@moishimwe moishimwe mentioned this pull request Jun 30, 2024
Open
@marcelineepi marcelineepi mentioned this pull request Jun 30, 2024
Open
@keemraheem keemraheem mentioned this pull request Jun 30, 2024
Open
@fakure2020 fakure2020 mentioned this pull request Jul 3, 2024
Open
This was referenced Jul 17, 2024
Open
Open
This was referenced Jul 17, 2024
Open
Open
Open
@virender-rathore-ml virender-rathore-ml mentioned this pull request Jul 18, 2024
Open
@harshakrithvikk harshakrithvikk mentioned this pull request Jul 24, 2024
Open
This was referenced Jul 28, 2024
Merged
Merged
@krischarbonneau krischarbonneau mentioned this pull request Jul 30, 2024
Closed
@SoniaBoussabeh SoniaBoussabeh mentioned this pull request Sep 11, 2024
Open
This was referenced Sep 12, 2024
Open
Open
Open
Open
Open
Open
Zirak pushed a commit to Zirak/opentelemetry-js that referenced this pull request Sep 14, 2024
@JohannesHuster @pichlermarc @Zirak
refactor(sdk-trace-node): Use tree-shakeable string constants for sem…
f5c0055 
…conv (open-telemetry#4748)

* refactor(sdk-trace-node): Use tree-shakeable string constants for semconv

* Update changelog

---------

Co-authored-by: Marc Pichler <marc.pichler@dynatrace.com>
This was referenced Sep 16, 2024
Open
Open
@gyenoch gyenoch mentioned this pull request Oct 3, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pichlermarc pichlermarc pichlermarc approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@JohannesHuster @pichlermarc