chore: prepare release 1.24.1/0.51.1 (backport bugfixes)#4682
Merged
pichlermarc merged 6 commits intoopen-telemetry:release/1.24.x-0.51.xfrom May 7, 2024
Merged
Conversation
…urce -> ...) (open-telemetry#4653) * fix(resources): prevent circular import (resource -> detector -> resource -> ...) * fixup! fix(resources): prevent circular import (resource -> detector -> resource -> ...)
…efaults() when a process polyfill is used (open-telemetry#4649) * fix(core): align inconsistent behavior of getEnv() and getEnvWithoutDefaults() when a process polyfill is used * Update CHANGELOG.md
open-telemetry#4678) * fix(exporter-metrics-otlp-grpc) Add explicit otlp-exporter-base dependency to exporter-metrics-otlp-grpc * Update CHANGELOG.md --------- Co-authored-by: Marc Pichler <marc.pichler@dynatrace.com>
Member
|
I reached out to Datadog about this through @Qard. As the PR currently stands it would break dd-trace which I would like to avoid. I think we should delay this for a short time in order to allow them to respond, but I don't want to delay it forever. |
Member
Author
@dyladan this is a PR that just backports bugfixes, I think you meant to comment over at #4677 🙂 |
Member
|
Thanks |
dyladan
approved these changes
May 7, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Backports bugfixes to 1.24.x and 0.51.x
Reason:
1.24.1
🐛 (Bug Fix)
getEnv()andgetEnvWithoutDefaults()when aprocesspolyfill is used #4648 @pichlermarcgetEnvWithoutDefaults()would useprocess.envif it was defined when running in a browser, whilegetEnv()would always use_globalThis. Now both use_globalThiswhen running in a browser.@opentelemetry/resources0.51.1
🐛 (Bug Fix)