Skip to content

Change http.request.body.size and http.response.body.size attributes from recommended to opt-in#9799

Merged
trask merged 2 commits into
open-telemetry:mainfrom
mateuszrzeszutek:http-body-size
Nov 2, 2023
Merged

Change http.request.body.size and http.response.body.size attributes from recommended to opt-in#9799
trask merged 2 commits into
open-telemetry:mainfrom
mateuszrzeszutek:http-body-size

Conversation

@mateuszrzeszutek

@mateuszrzeszutek mateuszrzeszutek commented Nov 2, 2023

Copy link
Copy Markdown
Member

@mateuszrzeszutek mateuszrzeszutek requested a review from a team November 2, 2023 15:44
trask
trask approved these changes Nov 2, 2023
View reviewed changes

@trask trask left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

heads up, I think my proposed change open-telemetry/semantic-conventions#461 would result in deleting the code (but makes sense to keep it until then)

@trask trask mentioned this pull request Nov 2, 2023
Closed
4 tasks
@mateuszrzeszutek

mateuszrzeszutek commented Nov 2, 2023

Copy link
Copy Markdown
Member Author

Hmm, the body size metrics too?
The only reason I introduced an experimental attributes extractor is to keep the experimental metrics working

@trask

trask commented Nov 2, 2023

Copy link
Copy Markdown
Member

Hmm, the body size metrics too?

I'm not sure, it's a good question, maybe we need *.header.content_length metrics, or maybe we could relax the metric definition to allow populating it just from content-length header

The only reason I introduced an experimental attributes extractor is to keep the experimental metrics working

👍

@mateuszrzeszutek

mateuszrzeszutek commented Nov 2, 2023

Copy link
Copy Markdown
Member Author

maybe we could relax the metric definition to allow populating it just from content-length header

Metric definition is one thing -- the limiting factor here is the OperationListener interface, actually. We can only produce metrics from Context and Attributes unfortunately

@trask trask merged commit d6c2aff into open-telemetry:main Nov 2, 2023
@mateuszrzeszutek mateuszrzeszutek deleted the http-body-size branch November 6, 2023 07:32
Abhishekkr3003 pushed a commit to Abhishekkr3003/opentelemetry-java-instrumentation that referenced this pull request Nov 7, 2023
@Abhishekkr3003
Change http.request.body.size and http.response.body.size attribu…
3c880b6 
…tes from recommended to opt-in (open-telemetry#9799)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@trask trask trask approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@mateuszrzeszutek @trask