Allow overriding span name in spring web library instrumentation#8933
Merged
Conversation
breedx-splk
approved these changes
Jul 12, 2023
breedx-splk
left a comment
Contributor
There was a problem hiding this comment.
Can you work this new behavior into one of the tests please? Even if it just appends an x to the span name or something, it would be nice to see this new functionality have test coverage.
mateuszrzeszutek
approved these changes
Jul 13, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #8839
In
spring-webmvcit is still possible that updating route overwrites the name from the span extractor.