Skip to content

Make the Spring autoconfiguration work with Spring Boot 3#8028

Merged
mateuszrzeszutek merged 1 commit into
open-telemetry:mainfrom
jeanbisutti:spring-boot-3-starter
Mar 13, 2023
Merged

Make the Spring autoconfiguration work with Spring Boot 3#8028
mateuszrzeszutek merged 1 commit into
open-telemetry:mainfrom
jeanbisutti:spring-boot-3-starter

Conversation

@jeanbisutti

Copy link
Copy Markdown
Member

This PR makes the Spring autoconfiguration work from Spring Boot 2.7.

The way to declare autoconfiguration has indeed changed from Spring Boot 2.7.

A workaround is to use @EnableOpenTelemetry.

@jeanbisutti jeanbisutti requested a review from a team March 10, 2023 18:59
@mateuszrzeszutek mateuszrzeszutek linked an issue Mar 13, 2023 that may be closed by this pull request
@mateuszrzeszutek mateuszrzeszutek merged commit 2bd2bbc into open-telemetry:main Mar 13, 2023
@amexboy

amexboy commented Mar 13, 2023

Copy link
Copy Markdown

I think the list is missing io.opentelemetry.instrumentation.spring.autoconfigure.webmvc.WebMvcFilterAutoConfigurationSpring6.

mateuszrzeszutek pushed a commit that referenced this pull request Mar 14, 2023
Related to
#8028 (comment)
spring boot 3 uses `jakarta.servlet` so we need to use
`WebMvcFilterAutoConfigurationSpring6 ` instead of
`WebMvcFilterAutoConfiguration`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Tracer Bean not created

4 participants