Skip to content

Make the OpenTelemetry Logback appender work with GraalVM native images#7989

Merged
trask merged 1 commit into
open-telemetry:mainfrom
jeanbisutti:logback-appender-graal
Mar 8, 2023
Merged

Make the OpenTelemetry Logback appender work with GraalVM native images#7989
trask merged 1 commit into
open-telemetry:mainfrom
jeanbisutti:logback-appender-graal

Conversation

@jeanbisutti

Copy link
Copy Markdown
Member

I have tried the OpenTelemetry Logback appender with GraalVM native images. The GraalVM configurations of this PR are required to make it work.

It's my first GraalVM-related PR in this repo. In future works, adding automatic tests with GraalVM on some programmatic instrumentation libraries may be interesting.

@jeanbisutti jeanbisutti requested a review from a team March 6, 2023 21:28

@trask trask left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jeanbisutti

Copy link
Copy Markdown
Member Author

nice 👍

would a test similar to https://github.com/open-telemetry/opentelemetry-java/blob/328dcf075a827ebe710274d020baafb978091b01/integration-tests/graal/src/test/java/io/opentelemetry/integrationtests/graal/JcToolsTest.java#L18 cover this?

or is initialize-at-build-time harder to test?

Set up has also to be added on the Github side. Can I do this with GraalVM automatic tests for several instrumentation libraries in another PR ?

It would be great if this PR could be integrated into the next OTel Java instrumentation release to unblock the usage of the OpenTelemetry Logback appender with native images.

From my first trials, OpenTelemetry JDBC and JVM Runtime Metrics libraries seem to work without the addition of other GraalVM configs (more extensive testing from automatic tests would probably allow to be more confident).

@trask

trask commented Mar 8, 2023

Copy link
Copy Markdown
Member

Can I do this with GraalVM automatic tests for several instrumentation libraries in another PR ?

👍

@trask trask merged commit ff73e95 into open-telemetry:main Mar 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants