Skip to content

Ktor client instrumentation#7982

Merged
mateuszrzeszutek merged 1 commit into
open-telemetry:mainfrom
awelless:ktor_client_instrumentation
Mar 7, 2023
Merged

Ktor client instrumentation#7982
mateuszrzeszutek merged 1 commit into
open-telemetry:mainfrom
awelless:ktor_client_instrumentation

Conversation

@awelless

@awelless awelless commented Mar 6, 2023 •
edited
Loading

Copy link
Copy Markdown
Contributor

Client implementation for Ktor 2.0.
Resolves #4972.

  • Moved server instrumentation under server package
  • Implemented a plugin for ktor HttpClient

@awelless awelless requested a review from a team March 6, 2023 08:14
@linux-foundation-easycla

linux-foundation-easycla Bot commented Mar 6, 2023 •
edited
Loading

Copy link
Copy Markdown

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: awelless / name: Alaksiej Ščarbaty (26c74c5)

@github-actions github-actions Bot requested a review from theletterf March 6, 2023 08:14
@linux-foundation-easycla

linux-foundation-easycla Bot commented Mar 6, 2023 •
edited
Loading

Copy link
Copy Markdown

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: awelless / name: Alaksiej Ščarbaty (058d32d)

@awelless awelless force-pushed the ktor_client_instrumentation branch from 8ba01a2 to 058d32d Compare March 6, 2023 08:28
@awelless awelless force-pushed the ktor_client_instrumentation branch from 058d32d to b1afbf3 Compare March 6, 2023 08:34
mateuszrzeszutek
mateuszrzeszutek approved these changes Mar 7, 2023
View reviewed changes

@mateuszrzeszutek mateuszrzeszutek left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @awelless !

@mateuszrzeszutek mateuszrzeszutek merged commit 3b4aeeb into open-telemetry:main Mar 7, 2023
@mateuszrzeszutek mateuszrzeszutek mentioned this pull request Mar 7, 2023
Merged
laurit pushed a commit that referenced this pull request Mar 7, 2023
Add HTTP client spans&metrics to Ktor entry in the supported libs doc (…
a217e77 
…#7997)

See #7982
@awelless awelless deleted the ktor_client_instrumentation branch March 7, 2023 14:29
@taskar82 taskar82 mentioned this pull request Mar 14, 2023
Closed
@laurit laurit mentioned this pull request Mar 27, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@laurit laurit laurit approved these changes

@theletterf theletterf Awaiting requested review from theletterf

+1 more reviewer

@mateuszrzeszutek mateuszrzeszutek mateuszrzeszutek approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add support for Ktor

3 participants

@awelless @laurit @mateuszrzeszutek