[exporters] Native Marshallers should always write SUM#8107
Merged
jack-berg merged 1 commit intoopen-telemetry:mainfrom Feb 25, 2026
Merged
[exporters] Native Marshallers should always write SUM#8107jack-berg merged 1 commit intoopen-telemetry:mainfrom
jack-berg merged 1 commit intoopen-telemetry:mainfrom
Conversation
|
|
aafdb80 to
cb1462b
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #8107 +/- ##
=========================================
Coverage 90.32% 90.32%
Complexity 7607 7607
=========================================
Files 839 839
Lines 22888 22888
Branches 2283 2283
=========================================
Hits 20673 20673
Misses 1506 1506
Partials 709 709 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Member
|
@mosesn can you sign the CLA? Thanks |
Contributor
Author
|
@jack-berg signed, sorry for the delay! |
Contributor
antonio-mazzini
added a commit
to antonio-mazzini/opentelemetry-java
that referenced
this pull request
Mar 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
We found that sometimes we would export bad values from otel when the sum was 0 when we were also exporting deltas. My colleague @natasha-aleksandrova found that this was because the native histogram marshalers would omit the sum, since they were using the old
serializeDoublemethod, instead ofserializeDoubleOptional.Solution
Update the marshallers to use
serializeDoubleOptionaland add a test. I confirmed that the test fails before the change, and passes after the change.Result
The native marshalers properly export the histogram even when the sum is 0!