Update to opentelemetry-configuration v0.3.0 #6733
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jack-berg
commented
Sep 20, 2024
...st/java/io/opentelemetry/sdk/extension/incubator/fileconfig/FileConfigurationCreateTest.java
Outdated
Show resolved
Hide resolved
jack-berg
commented
Sep 20, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6733 +/- ##
============================================
- Coverage 90.06% 90.02% -0.05%
- Complexity 6463 6474 +11
============================================
Files 718 718
Lines 19528 19568 +40
Branches 1923 1930 +7
============================================
+ Hits 17588 17616 +28
- Misses 1350 1353 +3
- Partials 590 599 +9 ☔ View full report in Codecov by Sentry. |
breedx-splk
approved these changes
Sep 26, 2024
Contributor
breedx-splk
left a comment
There was a problem hiding this comment.
Wow, that was a bit of a heavy lift there! Phew. Thanks for all that work, looks good to me overall, just had a few small suggestions.
| if (list.isEmpty()) { | ||
| return null; | ||
| } | ||
| if (!list.stream().allMatch(entry -> expectedType.isAssignableFrom(entry.getClass()))) { |
...tor/src/main/java/io/opentelemetry/sdk/extension/incubator/fileconfig/FileConfiguration.java
Outdated
Show resolved
Hide resolved
Comment on lines
-41
to
-43
| if (model.getPrometheus() != null) { | ||
| throw new ConfigurationException("prometheus exporter not supported in this context"); | ||
| } |
...bator/src/main/java/io/opentelemetry/sdk/extension/incubator/fileconfig/ResourceFactory.java
Outdated
Show resolved
Hide resolved
...incubator/src/main/java/io/opentelemetry/sdk/extension/incubator/fileconfig/ViewFactory.java
Show resolved
Hide resolved
...incubator/src/main/java/io/opentelemetry/sdk/extension/incubator/fileconfig/ViewFactory.java
Show resolved
Hide resolved
.../test/java/io/opentelemetry/sdk/extension/incubator/fileconfig/AttributeListFactoryTest.java
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Building against the latest opentelemetry-configuration commit to verify the upcoming 0.3 release checks out: open-telemetry/opentelemetry-configuration#105