-
Notifications
You must be signed in to change notification settings - Fork 50
[issuegenerator] trim component type suffix from component name #1255
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[issuegenerator] trim component type suffix from component name #1255
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1255 +/- ##
==========================================
+ Coverage 62.43% 62.48% +0.04%
==========================================
Files 65 65
Lines 4020 4025 +5
==========================================
+ Hits 2510 2515 +5
Misses 1278 1278
Partials 232 232 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Is this coming from a specific need? I find this to be a bit weird. It introduces a mismatch between the component name and the actual package name. |
|
getComponent is used for labels and it was generating different labels from the commonly used ones open-telemetry/opentelemetry-collector-contrib#42826 (comment) |
This is collector-specific, I think the reason for this was that some components had a name so long that not doing this made it so we would reach label length limits 😅 |
|
@dmathieu I understand this change makes issuegenerator less useful in context other than the Collector's. On githubgen we went with this option:
that made the tool a bit more generic while still satisfying this use case. Do you think that is an acceptable way of doing this? |
|
This change is fine by me. The only other user of issuegenerator (that I know of) is ebpf-profiler, it has a single go module and no tags are set on issue generation. So this is fine. |
Co-authored-by: Pablo Baeyens <pbaeyens31+github@gmail.com>
trim component type suffix from component name