Skip to content

Checked if instrument enabled before measuring in prometheus#7866

Merged
dmathieu merged 5 commits intoopen-telemetry:mainfrom
itssaharsh:enableprom
Feb 9, 2026
Merged

Checked if instrument enabled before measuring in prometheus#7866
dmathieu merged 5 commits intoopen-telemetry:mainfrom
itssaharsh:enableprom

Conversation

@itssaharsh
Copy link
Copy Markdown
Contributor

@itssaharsh itssaharsh commented Feb 3, 2026

This pr updates proemetheus instrumentation file to check if instrument enabled before measuring in prometheus.
tracked in #7800

Copilot AI review requested due to automatic review settings February 3, 2026 05:09
@codecov
Copy link
Copy Markdown

codecov Bot commented Feb 3, 2026 •
edited
Loading

Codecov Report

❌ Patch coverage is 66.66667% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 81.7%. Comparing base (647a41e) to head (8050bd1).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...ters/prometheus/internal/observ/instrumentation.go 66.6% 1 Missing and 3 partials ⚠️
Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##            main   #7866     +/-   ##
=======================================
- Coverage   81.7%   81.7%   -0.1%     
=======================================
  Files        304     304             
  Lines      23260   23265      +5     
=======================================
- Hits       19015   19013      -2     
- Misses      3860    3861      +1     
- Partials     385     391      +6
Files with missing lines Coverage Δ
...ters/prometheus/internal/observ/instrumentation.go 93.5% <66.6%> (-6.5%) ⬇️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copilot AI reviewed Feb 3, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

dashpole
dashpole reviewed Feb 3, 2026
View reviewed changes
Comment thread exporters/prometheus/internal/observ/instrumentation.go Outdated
Comment thread exporters/prometheus/internal/observ/instrumentation.go
Comment thread exporters/prometheus/internal/observ/instrumentation.go Outdated
@MrAlias MrAlias mentioned this pull request Feb 3, 2026
Closed
15 tasks
@dmathieu dmathieu added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Feb 9, 2026
@dmathieu dmathieu merged commit c3f955a into open-telemetry:main Feb 9, 2026
29 of 30 checks passed
@MrAlias MrAlias added this to the v1.41.0 milestone Feb 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@dmathieu dmathieu dmathieu approved these changes

@dashpole dashpole dashpole approved these changes

@MrAlias MrAlias Awaiting requested review from MrAlias MrAlias is a code owner

@XSAM XSAM Awaiting requested review from XSAM XSAM is a code owner

@pellared pellared Awaiting requested review from pellared pellared is a code owner

@flc1125 flc1125 Awaiting requested review from flc1125 flc1125 is a code owner

Assignees

No one assigned

Labels

Skip Changelog PRs that do not require a CHANGELOG.md entry

Projects

None yet

Milestone

v1.41.0

Development

Successfully merging this pull request may close these issues.

5 participants

@itssaharsh @dmathieu @dashpole @MrAlias