Hey, I wante to ask you check this but what if something changes in between time start (sorry i was wrong i was using your code as refrence to understand what the changes were )
if i.operationDuration.Enabled(ctx) {
extOp.start = time.Now()
}
duration := time.Since(e.start).Seconds()

Codecov Report

❌ Patch coverage is 89.28571% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 81.6%. Comparing base (c3f955a) to head (d5094f4).
⚠️ Report is 251 commits behind head on main.

@@           Coverage Diff           @@
##            main   #7813     +/-   ##
=======================================
- Coverage   81.7%   81.6%   -0.1%     
=======================================
  Files        304     304             
  Lines      23265   23277     +12     
=======================================
+ Hits       19013   19016      +3     
- Misses      3861    3862      +1     
- Partials     391     399      +8     

Could you add tests?

Hi. I can add tests.

Do you expect separate cases (drop inflight/exported/duration, plus “all dropped”), or is one view-based test enough to show that when an instrument is disabled we skip it and ExportLogs().End() still records the remaining metrics?

I think one test with subtests for each metric would be good.

Don't trust what the LLM says. Your test needs to fail before your changes, and pass after.
Here, it passes both before and after.

How would this be tested? Enabled is a performance improvement to avoid computing attributes when we know in advance the metric will be dropped. Using enabled or not shouldn't be a behavioral change, right?

Might be able to demonstrate it with a benchmark when a no-op meterprovider is used?

I added a unit test because another reviewer asked for tests. it basically just verifies we don’t call Add/Record when an instrument reports Enabled(ctx)==false.

If you’d prefer, I can drop the unit test and add a benchmark instead since this is mainly a perf improvement. What would you rather have?

Nice. I didn't think of that, and that works for me.

Awesome, thanks! I’ll fix the remaining lint issues and update the PR.