Prometheus exporter tests: iterate through all scopes rather than looking only at the first#7510
Merged
dmathieu merged 2 commits intoopen-telemetry:mainfrom Oct 16, 2025
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #7510 +/- ##
=====================================
Coverage 86.2% 86.2%
=====================================
Files 295 295
Lines 25864 25864
=====================================
+ Hits 22307 22308 +1
+ Misses 3184 3183 -1
Partials 373 373 🚀 New features to boost your workflow:
|
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
flc1125
approved these changes
Oct 15, 2025
dmathieu
approved these changes
Oct 15, 2025
dashpole
approved these changes
Oct 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Current State: Only inspected the first ScopeMetrics[0].
New: Iterates all ScopeMetrics to look for the four expected metrics anywhere.