Skip to content

Add a version const to otlptracehttp#7479

Merged
MrAlias merged 2 commits intoopen-telemetry:mainfrom
MrAlias:otlptracehttp-version
Oct 9, 2025
Merged

Add a version const to otlptracehttp#7479
MrAlias merged 2 commits intoopen-telemetry:mainfrom
MrAlias:otlptracehttp-version

Conversation

@MrAlias
Copy link
Copy Markdown
Contributor

@MrAlias MrAlias commented Oct 8, 2025

Part of #7006

@MrAlias MrAlias added this to the v1.39.0 milestone Oct 8, 2025
@MrAlias MrAlias added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Oct 8, 2025
@MrAlias MrAlias marked this pull request as ready for review October 8, 2025 20:37
@codecov
Copy link
Copy Markdown

codecov Bot commented Oct 8, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 85.8%. Comparing base (04ea40e) to head (3c1b54a).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@          Coverage Diff          @@
##            main   #7479   +/-   ##
=====================================
  Coverage   85.8%   85.8%           
=====================================
  Files        289     289           
  Lines      25377   25377           
=====================================
+ Hits       21774   21777    +3     
+ Misses      3222    3219    -3     
  Partials     381     381           

see 2 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@MrAlias MrAlias merged commit a817caa into open-telemetry:main Oct 9, 2025
31 checks passed
@MrAlias MrAlias deleted the otlptracehttp-version branch October 9, 2025 20:43
MrAlias added a commit that referenced this pull request Oct 9, 2025
Part of #7006

Contains TODOs to be resolved based on merge order of this and #7479.


### Benchmarks

```console
> benchstat bmark.results
goos: linux
goarch: amd64
pkg: go.opentelemetry.io/otel/exporters/otlp/otlptrace/otlptracehttp/internal/observ
cpu: Intel(R) Core(TM) i7-8550U CPU @ 1.80GHz
                                          │ bmark.results │
                                          │    sec/op     │
InstrumentationExportSpans/NoError-8          149.7n ± 3%
InstrumentationExportSpans/PartialError-8     1.774µ ± 9%
InstrumentationExportSpans/FullError-8        1.743µ ± 4%
geomean                                       773.3n

                                          │ bmark.results │
                                          │     B/op      │
InstrumentationExportSpans/NoError-8         0.000 ± 0%
InstrumentationExportSpans/PartialError-8    753.0 ± 0%
InstrumentationExportSpans/FullError-8       753.0 ± 0%
geomean                                                 ¹
¹ summaries must be >0 to compute geomean

                                          │ bmark.results │
                                          │   allocs/op   │
InstrumentationExportSpans/NoError-8         0.000 ± 0%
InstrumentationExportSpans/PartialError-8    4.000 ± 0%
InstrumentationExportSpans/FullError-8       4.000 ± 0%
geomean                                                 ¹
¹ summaries must be >0 to compute geomean
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Skip Changelog PRs that do not require a CHANGELOG.md entry

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants