Skip to content

sdk/trace/internal/x: generate x package from x component template #7385#7411

Merged
MrAlias merged 2 commits intoopen-telemetry:mainfrom
ternua8:trace/internal-x-generate
Sep 27, 2025
Merged

sdk/trace/internal/x: generate x package from x component template #7385#7411
MrAlias merged 2 commits intoopen-telemetry:mainfrom
ternua8:trace/internal-x-generate

Conversation

@ternua8
Copy link
Copy Markdown
Contributor

@ternua8 ternua8 commented Sep 25, 2025 •
edited by MrAlias
Loading

Fix #7385

Summary

This PR adds code generation for the sdk/trace/internal/x package
using the shared x component template.

It mirrors the implementation in sdk/log/internal/x (#7389) for the trace SDK.

Changes

  • Added gen.go to run go:generate for x.go and x_test.go.
  • Generated x/x.go and x/x_test.go using the shared template.
  • Added feature.go with the Observability experimental feature flag for the trace SDK,
    following the pattern used in the log SDK.

Verification

  • go generate ./... successfully generates the files.
  • Unit tests in x_test.go pass.

References

@linux-foundation-easycla
Copy link
Copy Markdown

linux-foundation-easycla Bot commented Sep 25, 2025 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: ternua8 / name: ternua8 (d5755e7)
  • ✅ login: MrAlias / name: Tyler Yahn (0e2fd7c)

@dmathieu dmathieu added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Sep 25, 2025
@codecov
Copy link
Copy Markdown

codecov Bot commented Sep 25, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 85.5%. Comparing base (fef6ee5) to head (0e2fd7c).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@          Coverage Diff          @@
##            main   #7411   +/-   ##
=====================================
  Coverage   85.5%   85.5%           
=====================================
  Files        277     278    +1     
  Lines      24654   24654           
=====================================
+ Hits       21088   21089    +1     
+ Misses      3187    3186    -1     
  Partials     379     379
Files with missing lines Coverage Δ
sdk/trace/internal/x/features.go 100.0% <100.0%> (ø)
sdk/trace/internal/x/x.go 100.0% <ø> (ø)

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

flc1125
flc1125 approved these changes Sep 25, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@flc1125 flc1125 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@flc1125 flc1125 linked an issue Sep 25, 2025 that may be closed by this pull request
sdk/trace/internal/x: generate x package from x component template #7385
Closed
@flc1125
Copy link
Copy Markdown
Member

flc1125 commented Sep 25, 2025

As an additional note: Since this issue was originally assigned to @adity1raut, we hope this PR can also be confirmed by @adity1raut (or if there are any other objections, please raise them).

@MrAlias MrAlias mentioned this pull request Sep 25, 2025
Closed
@MrAlias
Copy link
Copy Markdown
Contributor

MrAlias commented Sep 25, 2025 •
edited
Loading

@ternua8 thank you for your contribution. Going forward, please be sure to have the issue you are working on assigned to you and not someone else. Without doing so it can cause wasted effort and significant frustration for community members.

@ternua8
Copy link
Copy Markdown
Contributor Author

ternua8 commented Sep 26, 2025

Thank you for pointing this out. I’m still new here and learning the workflow, so I really appreciate the guidance. I’ll make sure to only take on issues that are assigned to me in the future.

@ternua8
Copy link
Copy Markdown
Contributor Author

ternua8 commented Sep 26, 2025

Recently I’ve been learning more about OpenTelemetry. If there are any beginner-friendly issues, I’d be happy to take them on.

@flc1125
Copy link
Copy Markdown
Member

flc1125 commented Sep 27, 2025

@adity1raut Hi, since there hasn't been a response yet, We will merge this PR later.

@MrAlias MrAlias merged commit 0db5ac7 into open-telemetry:main Sep 27, 2025
30 checks passed
@MrAlias MrAlias added this to the v1.39.0 milestone Oct 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dmathieu dmathieu dmathieu approved these changes

@MrAlias MrAlias MrAlias approved these changes

@flc1125 flc1125 flc1125 approved these changes

@XSAM XSAM Awaiting requested review from XSAM XSAM is a code owner

@dashpole dashpole Awaiting requested review from dashpole dashpole is a code owner

@pellared pellared Awaiting requested review from pellared pellared is a code owner

Assignees

No one assigned

Labels

Skip Changelog PRs that do not require a CHANGELOG.md entry

Projects

None yet

Milestone

v1.39.0

Development

Successfully merging this pull request may close these issues.

sdk/trace/internal/x: generate x package from x component template

4 participants

@ternua8 @flc1125 @MrAlias @dmathieu